Skip to content

Commit a69fe2d

Browse files
committed
Fix Host header is broken on virtual host, close AsyncHttpClient#907
1 parent 77dadda commit a69fe2d

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

src/main/java/com/ning/http/client/providers/netty/request/NettyRequestFactory.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,14 @@ else if (proxyServer != null && !(useProxyConnect(uri) && config.isUseRelativeUR
8383
}
8484

8585
private String hostHeader(Request request, Uri uri) {
86-
String host = request.getVirtualHost() != null ? request.getVirtualHost() : uri.getHost();
87-
int port = uri.getPort();
88-
return port == -1 || port == getSchemeDefaultPort(uri.getScheme()) ? host : host + ":" + port;
86+
String virtualHost = request.getVirtualHost();
87+
if (virtualHost != null)
88+
return virtualHost;
89+
else {
90+
String host = uri.getHost();
91+
int port = uri.getPort();
92+
return port == -1 || port == getSchemeDefaultPort(uri.getScheme()) ? host : host + ":" + port;
93+
}
8994
}
9095

9196
public String firstRequestOnlyAuthorizationHeader(Request request, Uri uri, ProxyServer proxyServer, Realm realm) throws IOException {

0 commit comments

Comments
 (0)