improve threading usage on discovery and fd

Author: kimchy

modules/elasticsearch/src/main/java/org/elasticsearch/discovery/zen/fd/MasterFaultDetection.java

@@ -208,9 +208,13 @@ private void handleTransportDisconnect(DiscoveryNode node) {
     }
 
     private void notifyDisconnectedFromMaster() {
-        for (Listener listener : listeners) {
-            listener.onDisconnectedFromMaster();
-        }
+        threadPool.cached().execute(new Runnable() {
+            @Override public void run() {
+                for (Listener listener : listeners) {
+                    listener.onDisconnectedFromMaster();
+                }
+            }
+        });
     }
 
     private void notifyMasterFailure(final DiscoveryNode masterNode, final String reason) {
@@ -297,6 +301,10 @@ public void stop() {
                                 }
                             }
                         }
+
+                        @Override public boolean spawn() {
+                            return false; // no need to spawn, we hardly do anything
+                        }
                     });
         }
     }

modules/elasticsearch/src/main/java/org/elasticsearch/discovery/zen/fd/NodesFaultDetection.java

@@ -176,10 +176,14 @@ private void handleTransportDisconnect(DiscoveryNode node) {
         }
     }
 
-    private void notifyNodeFailure(DiscoveryNode node, String reason) {
-        for (Listener listener : listeners) {
-            listener.onNodeFailure(node, reason);
-        }
+    private void notifyNodeFailure(final DiscoveryNode node, final String reason) {
+        threadPool.cached().execute(new Runnable() {
+            @Override public void run() {
+                for (Listener listener : listeners) {
+                    listener.onNodeFailure(node, reason);
+                }
+            }
+        });
     }
 
     private class SendPingRequest implements Runnable {
@@ -232,6 +236,10 @@ private SendPingRequest(DiscoveryNode node) {
                                 }
                             }
                         }
+
+                        @Override public boolean spawn() {
+                            return false; // no need to spawn, we hardly do anything
+                        }
                     });
         }
     }

modules/elasticsearch/src/main/java/org/elasticsearch/discovery/zen/ping/multicast/MulticastZenPing.java

@@ -262,6 +262,10 @@ class MulticastPingResponseRequestHandler extends BaseTransportRequestHandler<Mu
             }
             channel.sendResponse(VoidStreamable.INSTANCE);
         }
+
+        @Override public boolean spawn() {
+            return false;
+        }
     }
 
     static class MulticastPingResponse implements Streamable {
@@ -340,7 +344,7 @@ public void stop() {
 
                     if (!transportService.nodeConnected(requestingNode)) {
                         // do the connect and send on a thread pool
-                        threadPool.execute(new Runnable() {
+                        threadPool.cached().execute(new Runnable() {
                             @Override public void run() {
                                 // connect to the node if possible
                                 try {

modules/elasticsearch/src/main/java/org/elasticsearch/discovery/zen/ping/unicast/UnicastZenPing.java

@@ -240,6 +240,10 @@ private void sendPings(int id, TimeValue timeout, boolean wait) {
                         logger.warn("failed to send ping to [{}]", exp, node);
                     }
                 }
+
+                @Override public boolean spawn() {
+                    return false;
+                }
             });
         }
         if (wait) {
@@ -282,6 +286,10 @@ class UnicastPingRequestHandler extends BaseTransportRequestHandler<UnicastPingR
         @Override public void messageReceived(UnicastPingRequest request, TransportChannel channel) throws Exception {
             channel.sendResponse(handlePingRequest(request));
         }
+
+        @Override public boolean spawn() {
+            return false;
+        }
     }
 
     static class UnicastPingRequest implements Streamable {