Skip to content

Commit 9eaffb2

Browse files
committed
Don't "double" cache a facet filter / query facet, closes elastic#734.
1 parent 7274ed7 commit 9eaffb2

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

modules/elasticsearch/src/main/java/org/elasticsearch/search/facet/filter/FilterFacetCollector.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public class FilterFacetCollector extends AbstractFacetCollector {
4242

4343
public FilterFacetCollector(String facetName, Filter filter, FilterCache filterCache) {
4444
super(facetName);
45-
this.filter = filterCache.cache(filter);
45+
this.filter = filter;
4646
}
4747

4848
@Override protected void doSetNextReader(IndexReader reader, int docBase) throws IOException {

modules/elasticsearch/src/main/java/org/elasticsearch/search/facet/query/QueryFacetCollector.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,9 @@ public QueryFacetCollector(String facetName, Query query, FilterCache filterCach
4848
super(facetName);
4949
Filter possibleFilter = extractFilterIfApplicable(query);
5050
if (possibleFilter != null) {
51-
this.filter = filterCache.cache(possibleFilter);
51+
this.filter = possibleFilter;
5252
} else {
53-
this.filter = filterCache.cache(new QueryWrapperFilter(query));
53+
this.filter = new QueryWrapperFilter(query);
5454
}
5555
}
5656

0 commit comments

Comments
 (0)