Skip to content

Commit b75c689

Browse files
committed
no need to call maybe merge as part of flush, we do it async anyhow
1 parent 3abda3a commit b75c689

File tree

1 file changed

+0
-18
lines changed
  • modules/elasticsearch/src/main/java/org/elasticsearch/index/engine/robin

1 file changed

+0
-18
lines changed

modules/elasticsearch/src/main/java/org/elasticsearch/index/engine/robin/RobinEngine.java

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -578,24 +578,6 @@ private void innerDelete(Delete delete, IndexWriter writer) throws IOException {
578578

579579
// We can't do prepareCommit here, since we rely on the the segment version for the translog version
580580

581-
// call maybeMerge outside of the write lock since it gets called anyhow within commit/refresh
582-
// and we want not to suffer this cost within the write lock
583-
// only do it if we don't have an async merging going on, otherwise, we know that we won't do any
584-
// merge operation
585-
try {
586-
if (indexWriter.getMergePolicy() instanceof EnableMergePolicy) {
587-
((EnableMergePolicy) indexWriter.getMergePolicy()).enableMerge();
588-
}
589-
indexWriter.maybeMerge();
590-
} catch (Exception e) {
591-
flushing.set(false);
592-
throw new FlushFailedEngineException(shardId, e);
593-
} finally {
594-
// don't allow merge when committing under write lock
595-
if (indexWriter.getMergePolicy() instanceof EnableMergePolicy) {
596-
((EnableMergePolicy) indexWriter.getMergePolicy()).disableMerge();
597-
}
598-
}
599581
rwl.writeLock().lock();
600582
try {
601583
if (indexWriter == null) {

0 commit comments

Comments
 (0)