Search: A failed search request might get overrun when trying another shard, closes elastic#1403.

Author: kimchy

modules/elasticsearch/src/main/java/org/elasticsearch/action/search/SearchRequest.java

@@ -119,10 +119,9 @@ public SearchRequest(String[] indices, byte[] source) {
         return validationException;
     }
 
-    /**
-     * Internal.
-     */
-    public void beforeLocalFork() {
+    public void beforeStart() {
+        // we always copy over if needed, the reason is that a request might fail while being search remotely
+        // and then we need to keep the buffer around
         if (source != null && sourceUnsafe) {
             source = Arrays.copyOfRange(source, sourceOffset, sourceOffset + sourceLength);
             sourceOffset = 0;
@@ -135,6 +134,12 @@ public void beforeLocalFork() {
         }
     }
 
+    /**
+     * Internal.
+     */
+    public void beforeLocalFork() {
+    }
+
     /**
      * Should the listener be called on a separate thread if needed.
      */

modules/elasticsearch/src/main/java/org/elasticsearch/action/search/type/TransportSearchTypeAction.java

@@ -130,6 +130,7 @@ protected BaseAsyncAction(SearchRequest request, ActionListener<SearchResponse>
         }
 
         public void start() {
+            request.beforeStart();
             // count the local operations, and perform the non local ones
             int localOperations = 0;
             for (final ShardIterator shardIt : shardsIts) {