Skip to content

Commit d5dce70

Browse files
committed
count date histo using the wrong counts aggregator to return results when using time based setting interval
1 parent 90d9c15 commit d5dce70

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

modules/elasticsearch/src/main/java/org/elasticsearch/search/facet/datehistogram/CountDateHistogramFacetCollector.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,6 @@ public TLongLongHashMap counts() {
115115

116116
public static class IntervalDateHistogramProc extends DateHistogramProc {
117117

118-
private final TLongLongHashMap counts = new TLongLongHashMap();
119-
120118
private final long interval;
121119

122120
public IntervalDateHistogramProc(long interval) {

modules/test/integration/src/test/java/org/elasticsearch/test/integration/search/facet/SimpleFacetsTests.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1216,6 +1216,7 @@ protected Client getClient() {
12161216
.addFacet(dateHistogramFacet("stats2").field("date").interval("day").zone("-02:00"))
12171217
.addFacet(dateHistogramFacet("stats3").field("date").valueField("num").interval("day").zone("-02:00"))
12181218
.addFacet(dateHistogramFacet("stats4").field("date").valueScript("doc['num'].value * 2").interval("day").zone("-02:00"))
1219+
.addFacet(dateHistogramFacet("stats5").field("date").interval("24h"))
12191220
.execute().actionGet();
12201221

12211222
if (searchResponse.failedShards() > 0) {
@@ -1264,6 +1265,14 @@ protected Client getClient() {
12641265
assertThat(facet.entries().get(1).time(), equalTo(timeInMillis("2009-03-05", DateTimeZone.forOffsetHours(-2))));
12651266
assertThat(facet.entries().get(1).count(), equalTo(2l));
12661267
assertThat(facet.entries().get(1).total(), equalTo(10d));
1268+
1269+
facet = searchResponse.facets().facet("stats5");
1270+
assertThat(facet.name(), equalTo("stats5"));
1271+
assertThat(facet.entries().size(), equalTo(2));
1272+
assertThat(facet.entries().get(0).time(), equalTo(utcTimeInMillis("2009-03-05")));
1273+
assertThat(facet.entries().get(0).count(), equalTo(2l));
1274+
assertThat(facet.entries().get(1).time(), equalTo(utcTimeInMillis("2009-03-06")));
1275+
assertThat(facet.entries().get(1).count(), equalTo(1l));
12671276
}
12681277

12691278
private long utcTimeInMillis(String time) {

0 commit comments

Comments
 (0)