Skip to content

Commit 2ffab47

Browse files
committed
Fix typo: Negotiate instead of Negociate
1 parent 92ecdcc commit 2ffab47

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

client/src/main/java/org/asynchttpclient/netty/handler/intercept/ProxyUnauthorized407Interceptor.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
package org.asynchttpclient.netty.handler.intercept;
1515

1616
import static org.asynchttpclient.Dsl.realm;
17-
import static org.asynchttpclient.util.AuthenticatorUtils.getHeaderWithPrefix;
17+
import static org.asynchttpclient.util.AuthenticatorUtils.*;
1818
import static org.asynchttpclient.util.HttpConstants.Methods.CONNECT;
1919
import io.netty.channel.Channel;
2020
import io.netty.handler.codec.http.DefaultHttpHeaders;
@@ -137,7 +137,7 @@ public boolean exitAfterHandling407(//
137137

138138
case KERBEROS:
139139
case SPNEGO:
140-
if (getHeaderWithPrefix(proxyAuthHeaders, "Negociate") == null) {
140+
if (getHeaderWithPrefix(proxyAuthHeaders, NEGOTIATE) == null) {
141141
LOGGER.info("Can't handle 407 with Kerberos or Spnego realm as Proxy-Authenticate headers don't match");
142142
return false;
143143
}
@@ -195,7 +195,7 @@ private void kerberosProxyChallenge(Channel channel,//
195195
NettyResponseFuture<?> future) throws SpnegoEngineException {
196196

197197
String challengeHeader = SpnegoEngine.instance().generateToken(proxyServer.getHost());
198-
headers.set(HttpHeaders.Names.PROXY_AUTHORIZATION, "Negotiate " + challengeHeader);
198+
headers.set(HttpHeaders.Names.PROXY_AUTHORIZATION, NEGOTIATE + " " + challengeHeader);
199199
}
200200

201201
private void ntlmProxyChallenge(String authenticateHeader,//

client/src/main/java/org/asynchttpclient/netty/handler/intercept/Unauthorized401Interceptor.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
package org.asynchttpclient.netty.handler.intercept;
1515

1616
import static org.asynchttpclient.Dsl.realm;
17-
import static org.asynchttpclient.util.AuthenticatorUtils.getHeaderWithPrefix;
17+
import static org.asynchttpclient.util.AuthenticatorUtils.*;
1818
import io.netty.channel.Channel;
1919
import io.netty.handler.codec.http.DefaultHttpHeaders;
2020
import io.netty.handler.codec.http.HttpHeaders;
@@ -137,7 +137,7 @@ public boolean exitAfterHandling401(//
137137

138138
case KERBEROS:
139139
case SPNEGO:
140-
if (getHeaderWithPrefix(wwwAuthHeaders, "Negociate") == null) {
140+
if (getHeaderWithPrefix(wwwAuthHeaders, NEGOTIATE) == null) {
141141
LOGGER.info("Can't handle 401 with Kerberos or Spnego realm as WWW-Authenticate headers don't match");
142142
return false;
143143
}
@@ -214,6 +214,6 @@ private void kerberosChallenge(Channel channel,//
214214
Uri uri = request.getUri();
215215
String host = request.getVirtualHost() == null ? uri.getHost() : request.getVirtualHost();
216216
String challengeHeader = SpnegoEngine.instance().generateToken(host);
217-
headers.set(HttpHeaders.Names.AUTHORIZATION, "Negotiate " + challengeHeader);
217+
headers.set(HttpHeaders.Names.AUTHORIZATION, NEGOTIATE + " " + challengeHeader);
218218
}
219219
}

client/src/main/java/org/asynchttpclient/util/AuthenticatorUtils.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@
2828
import org.asynchttpclient.uri.Uri;
2929

3030
public final class AuthenticatorUtils {
31+
32+
public static final String NEGOTIATE = "Negotiate";
3133

3234
private static final String PROXY_AUTHORIZATION_HEADER = "Proxy-Authorization";
3335

@@ -173,7 +175,7 @@ else if (request.getVirtualHost() != null)
173175
host = request.getUri().getHost();
174176

175177
try {
176-
authorizationHeader = "Negotiate " + SpnegoEngine.instance().generateToken(host);
178+
authorizationHeader = NEGOTIATE + " " + SpnegoEngine.instance().generateToken(host);
177179
} catch (SpnegoEngineException e) {
178180
throw new RuntimeException(e);
179181
}

0 commit comments

Comments
 (0)