Drop unused request.getContentLength, close AsyncHttpClient#1138

Author: slandelle

client/src/main/java/org/asynchttpclient/DefaultRequest.java

@@ -51,7 +51,6 @@ public class DefaultRequest implements Request {
     private final List<Param> formParams;
     private final List<Part> bodyParts;
     private final String virtualHost;
-    private final long contentLength;
     public final ProxyServer proxyServer;
     private final Realm realm;
     private final File file;
@@ -79,7 +78,6 @@ public DefaultRequest(String method,//
             List<Param> formParams,//
             List<Part> bodyParts,//
             String virtualHost,//
-            long contentLength,//
             ProxyServer proxyServer,//
             Realm realm,//
             File file,//
@@ -104,7 +102,6 @@ public DefaultRequest(String method,//
         this.formParams = formParams;
         this.bodyParts = bodyParts;
         this.virtualHost = virtualHost;
-        this.contentLength = contentLength;
         this.proxyServer = proxyServer;
         this.realm = realm;
         this.file = file;
@@ -196,11 +193,6 @@ public String getVirtualHost() {
         return virtualHost;
     }
 
-    @Override
-    public long getContentLength() {
-        return contentLength;
-    }
-
     @Override
     public ProxyServer getProxyServer() {
         return proxyServer;

client/src/main/java/org/asynchttpclient/Request.java

@@ -119,13 +119,6 @@ public interface Request {
      */
     BodyGenerator getBodyGenerator();
 
-    /**
-     * Return the current size of the content-lenght header based on the body's size.
-     *
-     * @return the current size of the content-lenght header based on the body's size.
-     */
-    long getContentLength();
-
     /**
      * Return the current form parameters.
      *

client/src/main/java/org/asynchttpclient/RequestBuilderBase.java

@@ -80,7 +80,6 @@ public abstract class RequestBuilderBase<T extends RequestBuilderBase<T>> {
     protected List<Param> formParams;
     protected List<Part> bodyParts;
     protected String virtualHost;
-    protected long contentLength = -1;
     protected ProxyServer proxyServer;
     protected Realm realm;
     protected File file;
@@ -129,7 +128,6 @@ protected RequestBuilderBase(Request prototype, boolean disableUrlEncoding, bool
             this.bodyParts = new ArrayList<>(prototype.getBodyParts());
         }
         this.virtualHost = prototype.getVirtualHost();
-        this.contentLength = prototype.getContentLength();
         this.proxyServer = prototype.getProxyServer();
         this.realm = prototype.getRealm();
         this.file = prototype.getFile();
@@ -204,11 +202,6 @@ public T setHeaders(Map<String, Collection<String>> headers) {
         return asDerivedType();
     }
 
-    public T setContentLength(int contentLength) {
-        this.contentLength = contentLength;
-        return asDerivedType();
-    }
-
     private void lazyInitCookies() {
         if (this.cookies == null)
             this.cookies = new ArrayList<>(3);
@@ -267,7 +260,6 @@ public void resetNonMultipartData() {
         this.stringData = null;
         this.streamData = null;
         this.bodyGenerator = null;
-        this.contentLength = -1;
     }
 
     public void resetMultipartData() {
@@ -472,7 +464,6 @@ private RequestBuilderBase<?> executeSignatureCalculator() {
         rb.streamData = this.streamData;
         rb.bodyGenerator = this.bodyGenerator;
         rb.virtualHost = this.virtualHost;
-        rb.contentLength = this.contentLength;
         rb.proxyServer = this.proxyServer;
         rb.realm = this.realm;
         rb.file = this.file;
@@ -508,22 +499,6 @@ private Charset computeCharset() {
         return this.charset;
     }
 
-    private long computeRequestContentLength() {
-        if (this.contentLength < 0 && this.streamData == null) {
-            // can't concatenate content-length
-            final String contentLength = this.headers.get(HttpHeaders.Names.CONTENT_LENGTH);
-
-            if (contentLength != null) {
-                try {
-                    return Long.parseLong(contentLength);
-                } catch (NumberFormatException e) {
-                    // NoOp -- we won't specify length so it will be chunked?
-                }
-            }
-        }
-        return this.contentLength;
-    }
-
     private Uri computeUri() {
 
         Uri tempUri = this.uri;
@@ -541,7 +516,6 @@ public Request build() {
         RequestBuilderBase<?> rb = executeSignatureCalculator();
         Uri finalUri = rb.computeUri();
         Charset finalCharset = rb.computeCharset();
-        long finalContentLength = rb.computeRequestContentLength();
 
         // make copies of mutable internal collections
         List<Cookie> cookiesCopy = rb.cookies == null ? Collections.emptyList() : new ArrayList<>(rb.cookies);
@@ -563,7 +537,6 @@ public Request build() {
                 formParamsCopy,//
                 bodyPartsCopy,//
                 rb.virtualHost,//
-                finalContentLength,//
                 rb.proxyServer,//
                 rb.realm,//
                 rb.file,//