Skip to content

Commit b87eccd

Browse files
committed
Move all icons into one sprite file, simplify icon markup
1 parent abd0db3 commit b87eccd

File tree

5 files changed

+61
-35
lines changed

5 files changed

+61
-35
lines changed

_includes/footer.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,25 +29,25 @@ <h2 class="visually-hidden">{{ site.title }}></h2>
2929
<ul class="footer-social-list list--inline">
3030
<li class="footer-social-list__item">
3131
<a class="footer-link no-underline" href="https://www.twitter.com/{{ site.twitter_username| cgi_escape | escape }}">
32-
<svg class="svg-icon"><use xlink:href="{{ '/assets/images/icons/social-icons.svg#twitter' | relative_url }}"></use></svg>
32+
<svg class="svg-icon"><use xlink:href="{{ '/assets/images/icons/icon-sprite.svg#twitter' | relative_url }}"></use></svg>
3333
<span class="visually-hidden">Scribd on Twitter</span>
3434
</a>
3535
</li>
3636
<li class="footer-social-list__item">
3737
<a class="footer-link no-underline" href="https://www.facebook.com/{{ site.facebook_username| cgi_escape | escape }}">
38-
<svg class="svg-icon"><use xlink:href="{{ '/assets/images/icons/social-icons.svg#facebook' | relative_url }}"></use></svg>
38+
<svg class="svg-icon"><use xlink:href="{{ '/assets/images/icons/icon-sprite.svg#facebook' | relative_url }}"></use></svg>
3939
<span class="visually-hidden">Scribd on Facebook</span>
4040
</a>
4141
</li>
4242
<li class="footer-social-list__item">
4343
<a class="footer-link no-underline" href="https://www.linkedin.com/company/{{ site.linkedin_username| cgi_escape | escape }}">
44-
<svg class="svg-icon"><use xlink:href="{{ '/assets/images/icons/social-icons.svg#linkedin' | relative_url }}"></use></svg>
44+
<svg class="svg-icon"><use xlink:href="{{ '/assets/images/icons/icon-sprite.svg#linkedin' | relative_url }}"></use></svg>
4545
<span class="visually-hidden">Scribd on LinkedIn</span>
4646
</a>
4747
</li>
4848
<li class="footer-social-list__item">
4949
<a class="footer-link no-underline" href="https://github.com/{{ site.github_username| cgi_escape | escape }}">
50-
<svg class="svg-icon"><use xlink:href="{{ '/assets/images/icons/social-icons.svg#github' | relative_url }}"></use></svg>
50+
<svg class="svg-icon"><use xlink:href="{{ '/assets/images/icons/icon-sprite.svg#github' | relative_url }}"></use></svg>
5151
<span class="visually-hidden">Scribd on Github</span>
5252
</a>
5353
</li>

_includes/header.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,19 +40,19 @@ <h1 class="visually-hidden">{{ site.title }}</h1>
4040
<!-- Social icons (mobile only) -->
4141
<li class="nav-social-list hidden-md">
4242
<a class="nav-social-list__item text-white no-underline" href="https://www.twitter.com/{{ site.twitter_username| cgi_escape | escape }}">
43-
<svg class="svg-icon"><use xlink:href="{{ '/assets/images/icons/social-icons.svg#twitter' | relative_url }}"></use></svg>
43+
<svg class="svg-icon"><use xlink:href="{{ '/assets/images/icons/icon-sprite.svg#twitter' | relative_url }}"></use></svg>
4444
<span class="visually-hidden">Scribd on Twitter</span>
4545
</a>
4646
<a class="nav-social-list__item text-white no-underline" href="https://www.facebook.com/{{ site.facebook_username| cgi_escape | escape }}">
47-
<svg class="svg-icon"><use xlink:href="{{ '/assets/images/icons/social-icons.svg#facebook' | relative_url }}"></use></svg>
47+
<svg class="svg-icon"><use xlink:href="{{ '/assets/images/icons/icon-sprite.svg#facebook' | relative_url }}"></use></svg>
4848
<span class="visually-hidden">Scribd on Facebook</span>
4949
</a>
5050
<a class="nav-social-list__item text-white no-underline" href="https://www.linkedin.com/company/{{ site.linkedin_username| cgi_escape | escape }}">
51-
<svg class="svg-icon"><use xlink:href="{{ '/assets/images/icons/social-icons.svg#linkedin' | relative_url }}"></use></svg>
51+
<svg class="svg-icon"><use xlink:href="{{ '/assets/images/icons/icon-sprite.svg#linkedin' | relative_url }}"></use></svg>
5252
<span class="visually-hidden">Scribd on LinkedIn</span>
5353
</a>
5454
<a class="nav-social-list__item text-white no-underline" href="https://github.com/{{ site.github_username| cgi_escape | escape }}">
55-
<svg class="svg-icon"><use xlink:href="{{ '/assets/images/icons/social-icons.svg#github' | relative_url }}"></use></svg>
55+
<svg class="svg-icon"><use xlink:href="{{ '/assets/images/icons/icon-sprite.svg#github' | relative_url }}"></use></svg>
5656
<span class="visually-hidden">Scribd on Github</span>
5757
</a>
5858
</li>

assets/images/icons/icon-sprite.svg

Lines changed: 53 additions & 0 deletions
Loading

assets/images/icons/icons.svg

Lines changed: 0 additions & 9 deletions
This file was deleted.

assets/images/icons/social-icons.svg

Lines changed: 0 additions & 18 deletions
This file was deleted.

0 commit comments

Comments
 (0)