Remove PhabricatorRepository::loadAllByPHIDOrCallsign()

Summary: Ref T603. Move to real Query classes.

Test Plan:
  - Ran `phd debug pull X` (where `X` does not match a repository).
  - Ran `phd debug pull Y` (where `Y` does match a repository).
  - Ran `phd debug pull`.
  - Ran `repository pull`.
  - Ran `repository pull X`.
  - Ran `repository pull Y`.
  - Ran `repository discover`.
  - Ran `repository delete`.
  - Ran `grep`.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D7137

Author: epriestley

src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php

@@ -176,11 +176,26 @@ public function run() {
    * @task pull
    */
   protected function loadRepositories(array $names) {
-    if (!count($names)) {
-      return id(new PhabricatorRepository())->loadAll();
-    } else {
-      return PhabricatorRepository::loadAllByPHIDOrCallsign($names);
+    $query = id(new PhabricatorRepositoryQuery())
+      ->setViewer($this->getViewer());
+
+    if ($names) {
+      $query->withCallsigns($names);
+    }
+
+    $repos = $query->execute();
+
+    if ($names) {
+      $by_callsign = mpull($repos, null, 'getCallsign');
+      foreach ($names as $name) {
+        if (empty($by_callsign[$name])) {
+          throw new Exception(
+            "No repository exists with callsign '{$name}'!");
+        }
+      }
     }
+
+    return $repos;
   }
 
   public function discoverRepository(PhabricatorRepository $repository) {

src/applications/repository/management/PhabricatorRepositoryManagementDeleteWorkflow.php

@@ -7,7 +7,7 @@ public function didConstruct() {
     $this
       ->setName('delete')
       ->setExamples('**delete** __repository__ ...')
-      ->setSynopsis('Delete __repository__, named by callsign or PHID.')
+      ->setSynopsis('Delete __repository__, named by callsign.')
       ->setArguments(
         array(
           array(
@@ -22,12 +22,11 @@ public function didConstruct() {
   }
 
   public function execute(PhutilArgumentParser $args) {
-    $names = $args->getArg('repos');
-    $repos = PhabricatorRepository::loadAllByPHIDOrCallsign($names);
+    $repos = $this->loadRepositories($args, 'repos');
 
     if (!$repos) {
       throw new PhutilArgumentUsageException(
-        "Specify one or more repositories to delete, by callsign or PHID.");
+        "Specify one or more repositories to delete, by callsign.");
     }
 
     $console = PhutilConsole::getConsole();

src/applications/repository/management/PhabricatorRepositoryManagementDiscoverWorkflow.php

@@ -7,7 +7,7 @@ public function didConstruct() {
     $this
       ->setName('discover')
       ->setExamples('**discover** [__options__] __repository__ ...')
-      ->setSynopsis('Discover __repository__, named by callsign or PHID.')
+      ->setSynopsis('Discover __repository__, named by callsign.')
       ->setArguments(
         array(
           array(
@@ -27,12 +27,11 @@ public function didConstruct() {
   }
 
   public function execute(PhutilArgumentParser $args) {
-    $names = $args->getArg('repos');
-    $repos = PhabricatorRepository::loadAllByPHIDOrCallsign($names);
+    $repos = $this->loadRepositories($args, 'repos');
 
     if (!$repos) {
       throw new PhutilArgumentUsageException(
-        "Specify one or more repositories to discover, by callsign or PHID.");
+        "Specify one or more repositories to discover, by callsign.");
     }
 
     $console = PhutilConsole::getConsole();

src/applications/repository/management/PhabricatorRepositoryManagementPullWorkflow.php

@@ -7,7 +7,7 @@ public function didConstruct() {
     $this
       ->setName('pull')
       ->setExamples('**pull** __repository__ ...')
-      ->setSynopsis('Pull __repository__, named by callsign or PHID.')
+      ->setSynopsis('Pull __repository__, named by callsign.')
       ->setArguments(
         array(
           array(
@@ -22,12 +22,11 @@ public function didConstruct() {
   }
 
   public function execute(PhutilArgumentParser $args) {
-    $names = $args->getArg('repos');
-    $repos = PhabricatorRepository::loadAllByPHIDOrCallsign($names);
+    $repos = $this->loadRepositories($args, 'repos');
 
     if (!$repos) {
       throw new PhutilArgumentUsageException(
-        "Specify one or more repositories to pull, by callsign or PHID.");
+        "Specify one or more repositories to pull, by callsign.");
     }
 
     $console = PhutilConsole::getConsole();

src/applications/repository/management/PhabricatorRepositoryManagementWorkflow.php

@@ -7,4 +7,28 @@ public function isExecutable() {
     return true;
   }
 
+  protected function loadRepositories(PhutilArgumentParser $args, $param) {
+    $callsigns = $args->getArg($param);
+
+    if (!$callsigns) {
+      return null;
+    }
+
+    $repos = id(new PhabricatorRepositoryQuery())
+      ->setViewer(PhabricatorUser::getOmnipotentUser())
+      ->withCallsigns($callsigns)
+      ->execute();
+
+    $repos = mpull($repos, null, 'getCallsign');
+    foreach ($callsigns as $callsign) {
+      if (empty($repos[$callsign])) {
+        throw new PhutilArgumentUsageException(
+          "No repository with callsign '{$callsign}' exists!");
+      }
+    }
+
+    return $repos;
+  }
+
+
 }

src/applications/repository/storage/PhabricatorRepository.php

@@ -451,24 +451,6 @@ public function formatCommitName($commit_identifier) {
     return 'r'.$this->getCallsign().$short_identifier;
   }
 
-  public static function loadAllByPHIDOrCallsign(array $names) {
-    // TODO: (T603) Get rid of this.
-
-    $repositories = array();
-    foreach ($names as $name) {
-      $repo = id(new PhabricatorRepository())->loadOneWhere(
-        'phid = %s OR callsign = %s',
-        $name,
-        $name);
-      if (!$repo) {
-        throw new Exception(
-          "No repository with PHID or callsign '{$name}' exists!");
-      }
-      $repositories[$repo->getID()] = $repo;
-    }
-    return $repositories;
-  }
-
 /* -(  Repository URI Management  )------------------------------------------ */
 
 

src/infrastructure/daemon/PhabricatorDaemon.php

@@ -14,4 +14,9 @@ protected function willSleep($duration) {
     LiskDAO::closeAllConnections();
     return;
   }
+
+  public function getViewer() {
+    return PhabricatorUser::getOmnipotentUser();
+  }
+
 }