Clean up warnings

Author: Stephane Landelle

api/src/main/java/org/asynchttpclient/AsyncHttpClientConfigDefaults.java

@@ -14,10 +14,6 @@
 
 import static org.asynchttpclient.util.MiscUtils.getBoolean;
 
-import org.asynchttpclient.util.DefaultHostnameVerifier;
-
-import javax.net.ssl.HostnameVerifier;
-
 public final class AsyncHttpClientConfigDefaults {
 
     private AsyncHttpClientConfigDefaults() {

api/src/main/java/org/asynchttpclient/util/ProxyHostnameChecker.java

@@ -33,6 +33,7 @@ public ProxyHostnameChecker() {
     private Object getHostnameChecker() {
         final ClassLoader classLoader = Thread.currentThread().getContextClassLoader();
         try {
+            @SuppressWarnings("unchecked")
             final Class<Object> hostnameCheckerClass = (Class<Object>) classLoader.loadClass("sun.security.util.HostnameChecker");
             final Method instanceMethod = hostnameCheckerClass.getMethod("getInstance", Byte.TYPE);
             return instanceMethod.invoke(null, TYPE_TLS);

api/src/test/java/org/asynchttpclient/async/util/TestUtils.java

@@ -3,7 +3,6 @@
 import static org.testng.Assert.assertEquals;
 
 import org.apache.commons.io.FileUtils;
-import org.asynchttpclient.async.HostnameVerifierTest;
 import org.asynchttpclient.util.StandardCharsets;
 import org.eclipse.jetty.security.ConstraintMapping;
 import org.eclipse.jetty.security.ConstraintSecurityHandler;

api/src/test/java/org/asynchttpclient/websocket/CloseCodeReasonMessageTest.java

@@ -109,7 +109,7 @@ public void wrongStatusCode() throws Throwable {
             final CountDownLatch latch = new CountDownLatch(1);
             final AtomicReference<Throwable> throwable = new AtomicReference<Throwable>();
 
-            WebSocket websocket = c.prepareGet("http://apache.org/").execute(new WebSocketUpgradeHandler.Builder().addWebSocketListener(new WebSocketTextListener() {
+            c.prepareGet("http://apache.org/").execute(new WebSocketUpgradeHandler.Builder().addWebSocketListener(new WebSocketTextListener() {
 
                 @Override
                 public void onMessage(String message) {
@@ -149,7 +149,7 @@ public void wrongProtocolCode() throws Throwable {
             final CountDownLatch latch = new CountDownLatch(1);
             final AtomicReference<Throwable> throwable = new AtomicReference<Throwable>();
 
-            WebSocket websocket = c.prepareGet("ws://www.google.com").execute(new WebSocketUpgradeHandler.Builder().addWebSocketListener(new WebSocketTextListener() {
+            c.prepareGet("ws://www.google.com").execute(new WebSocketUpgradeHandler.Builder().addWebSocketListener(new WebSocketTextListener() {
 
                 @Override
                 public void onMessage(String message) {

providers/netty/src/main/java/org/asynchttpclient/providers/netty/request/NettyConnectListener.java

@@ -87,7 +87,7 @@ private void writeRequest(Channel channel) {
     public void onFutureSuccess(final Channel channel) throws ConnectException {
         Channels.setAttribute(channel, future);
         final HostnameVerifier hostnameVerifier = config.getHostnameVerifier();
-        final SslHandler sslHandler = channelManager.getSslHandler(channel.pipeline());
+        final SslHandler sslHandler = ChannelManager.getSslHandler(channel.pipeline());
         if (hostnameVerifier != null && sslHandler != null) {
             final String host = future.getURI().getHost();
             sslHandler.handshakeFuture().addListener(new GenericFutureListener<Future<? super Channel>>() {

providers/netty/src/main/java/org/asynchttpclient/providers/netty/request/NettyRequestSender.java

@@ -141,6 +141,7 @@ private <T> ListenableFuture<T> sendRequestWithCertainForceConnect(//
      * until we get a valid channel from the pool and it's still valid once the
      * request is built
      */
+    @SuppressWarnings("unused")
     private <T> ListenableFuture<T> sendRequestThroughSslProxy(//
             Request request,//
             AsyncHandler<T> asyncHandler,//
@@ -443,6 +444,7 @@ public boolean applyIoExceptionFiltersAndReplayRequest(NettyResponseFuture<?> fu
 
         boolean replayed = false;
 
+        @SuppressWarnings({ "unchecked", "rawtypes" })
         FilterContext<?> fc = new FilterContext.FilterContextBuilder().asyncHandler(future.getAsyncHandler()).request(future.getRequest()).ioException(e).build();
         for (IOExceptionFilter asyncFilter : config.getIOExceptionFilters()) {
             try {

providers/netty/src/main/java/org/asynchttpclient/providers/netty/request/body/NettyBodyBody.java

@@ -19,7 +19,6 @@
 import org.asynchttpclient.RandomAccessBody;
 import org.asynchttpclient.providers.netty.NettyAsyncHttpProviderConfig;
 import org.asynchttpclient.providers.netty.channel.ChannelManager;
-import org.asynchttpclient.providers.netty.channel.Channels;
 import org.asynchttpclient.providers.netty.future.NettyResponseFuture;
 import org.asynchttpclient.providers.netty.request.ProgressListener;
 import org.asynchttpclient.providers.netty.request.body.FeedableBodyGenerator.FeedListener;