Skip to content

Commit 6918cce

Browse files
author
Stephane Landelle
committed
Do not block the WebSocket from receiving bytes or text fragments, close AsyncHttpClient#660
1 parent b01e94f commit 6918cce

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

providers/netty/src/main/java/org/asynchttpclient/providers/netty/ws/NettyWebSocket.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -179,10 +179,8 @@ private boolean hasWebSocketTextListener() {
179179
@Override
180180
public WebSocket addWebSocketListener(WebSocketListener l) {
181181
listeners.add(l);
182-
if (l instanceof WebSocketByteListener)
183-
interestedInByteMessages = true;
184-
else if (l instanceof WebSocketTextListener)
185-
interestedInTextMessages = true;
182+
interestedInByteMessages = interestedInByteMessages || l instanceof WebSocketByteListener;
183+
interestedInTextMessages = interestedInTextMessages || l instanceof WebSocketTextListener;
186184
return this;
187185
}
188186

@@ -192,7 +190,7 @@ public WebSocket removeWebSocketListener(WebSocketListener l) {
192190

193191
if (l instanceof WebSocketByteListener)
194192
interestedInByteMessages = hasWebSocketByteListener();
195-
else if (l instanceof WebSocketTextListener)
193+
if (l instanceof WebSocketTextListener)
196194
interestedInTextMessages = hasWebSocketTextListener();
197195

198196
return this;

0 commit comments

Comments
 (0)