Fix NPE when passing a null charset, close AsyncHttpClient#651

Author: Stephane Landelle

api/src/main/java/org/asynchttpclient/multipart/StringPart.java

@@ -18,6 +18,8 @@
 import java.nio.channels.WritableByteChannel;
 import java.nio.charset.Charset;
 
+import org.asynchttpclient.util.StandardCharsets;
+
 public class StringPart extends PartBase {
 
     /**
@@ -28,7 +30,7 @@ public class StringPart extends PartBase {
     /**
      * Default charset of string parameters
      */
-    public static final String DEFAULT_CHARSET = "US-ASCII";
+    public static final Charset DEFAULT_CHARSET = StandardCharsets.US_ASCII;
 
     /**
      * Default transfer encoding of string parameters
@@ -40,6 +42,10 @@ public class StringPart extends PartBase {
      */
     private final byte[] content;
 
+    private static Charset charsetOrDefault(String charset) {
+        return charset == null ? DEFAULT_CHARSET : Charset.forName(charset);
+    }
+
     public StringPart(String name, String value, String charset) {
         this(name, value, charset, null);
     }
@@ -58,15 +64,13 @@ public StringPart(String name, String value, String charset) {
      */
     public StringPart(String name, String value, String charset, String contentId) {
 
-        super(name, DEFAULT_CONTENT_TYPE, charset == null ? DEFAULT_CHARSET : charset, DEFAULT_TRANSFER_ENCODING, contentId);
-        if (value == null) {
+        super(name, DEFAULT_CONTENT_TYPE, charsetOrDefault(charset).name(), DEFAULT_TRANSFER_ENCODING, contentId);
+        if (value == null)
             throw new NullPointerException("value");
-        }
-        if (value.indexOf(0) != -1) {
+        if (value.indexOf(0) != -1)
             // See RFC 2048, 2.8. "8bit Data"
             throw new IllegalArgumentException("NULs may not be present in string parts");
-        }
-        content = value.getBytes(Charset.forName(charset));
+        content = value.getBytes(charsetOrDefault(charset));
     }
 
     /**