Reverse & fix top 10 list order, remove 2 x test console.logs

Author: mattpass

assets/js/icecoder.js

@@ -3417,9 +3417,9 @@ var ICEcoder = {
                 // If the innerHTML of that doesn't contain our new item, we can insert it
                 if(last10Files.innerHTML.indexOf(newFile) == -1) {
                     // Get the last 10 files list, pop the last one off and add newFile at start
-                    last10FilesList = last10Files.innerHTML.split("\n");
+                    last10FilesList = last10Files.innerHTML.split("\n");;
                     if (
-                        last10FilesList.length >= 10 ||													// No more than 10
+                        last10FilesList.length > 8 ||													// No more than 8 + 1 we're about to add
                         last10FilesList[0] == '<div style="display: inline-block; margin-left: -39px; margin-top: -4px">[none]</div><br><br>' ||	// Clear out placeholder
                         last10FilesList[last10FilesList.length-1] == ""											// No empty array items
                     ) {

editor.php

@@ -134,15 +134,15 @@
             if (empty($ICEcoder["last10Files"])) {
                 echo '<div style="display: inline-block; margin-left: -39px; margin-top: -4px">' . $t['none'] . '</div><br>';
             } else {
-                for ($i = 0; $i < count($ICEcoder["last10Files"]); $i++) {
+                for ($i = count($ICEcoder["last10Files"]) - 1; $i >= 0; $i--) {
                     $fileFolderName = str_replace("\\", "/", $ICEcoder["last10Files"][$i]);
                     // Get extension (prefix 'ext-' to prevent invalid classes from extensions that begin with numbers)
                     $ext = "ext-" . pathinfo($docRoot . $iceRoot . $fileFolderName, PATHINFO_EXTENSION);
                     echo '<li class="pft-file ' . strtolower($ext) . '" style="margin-left: -21px">';
                     echo '<a style="cursor:pointer" onClick="parent.ICEcoder.openFile(\'' . str_replace($docRoot, "", str_replace("|", "/", $ICEcoder["last10Files"][$i])) . '\')">';
                     echo str_replace($docRoot, "", str_replace("|", "/", $ICEcoder["last10Files"][$i]));
                     echo '</a></li>';
-                    if ($i < count($ICEcoder["last10Files"]) - 1) {
+                    if ($i > 0) {
                         echo PHP_EOL;
                     };
                 }

lib/settings-save-current-files.php

@@ -26,16 +26,13 @@
 			$inLast10Files = in_array($saveFilesArray[$i], $ICEcoder["last10Files"]);
 			if (false === $inLast10Files && "" !== $saveFilesArray[$i]) {
                 $ICEcoder["last10Files"][] = $saveFilesArray[$i];
-                echo "<script>console.log(".count($saveFilesArray).count($ICEcoder["last10Files"]).");</script>";
 				if (10 <= count($ICEcoder["last10Files"])) {
-				    $ICEcoder["last10Files"] = array_slice($ICEcoder["last10Files"], 0, 10);
+				    $ICEcoder["last10Files"] = array_slice($ICEcoder["last10Files"], -10, 10);
 				};
 				// Now update the config file
 				if (false === $settingsClass->saveLast10Files($settingsFile, $ICEcoder["last10Files"])) {
 					echo "<script>parent.parent.ICEcoder.message('".$t['Cannot update config...']." data/".$settingsFile." ".$t['and try again']."');</script>";
-				} else {
-                    echo "<script>console.log(".$ICEcoder["last10Files"][$i].");</script>";
-                }
+				}
 			}
 		}
 	}