array_splice not unset to change int array keys

mattpass · mattpass · commit f54460319f51 · 2020-07-21T09:21:10.000+01:00
diff --git a/lib/settings.php b/lib/settings.php
@@ -99,7 +99,7 @@
 // Remove any previous files that are no longer there
 for ($i = 0; $i < count($ICEcoderUserSettings['previousFiles']); $i++) {
     if (false === file_exists(str_replace("|", "/", $ICEcoderUserSettings['previousFiles'][$i]))) {
-        unset($ICEcoderUserSettings['previousFiles'][$i]);
+        array_splice($ICEcoderUserSettings['previousFiles'], $i, 1);
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@`
`99`	`99`	`// Remove any previous files that are no longer there`
`100`	`100`	`for ($i = 0; $i < count($ICEcoderUserSettings['previousFiles']); $i++) {`
`101`	`101`	`if (false === file_exists(str_replace("\|", "/", $ICEcoderUserSettings['previousFiles'][$i]))) {`
`102`		`- unset($ICEcoderUserSettings['previousFiles'][$i]);`
	`102`	`+ array_splice($ICEcoderUserSettings['previousFiles'], $i, 1);`
`103`	`103`	`}`
`104`	`104`	`}`
`105`	`105`