More error handling

Author: Issac Trotts

appengine/standard/wordpress/gen-wp-config

@@ -24,11 +24,16 @@ DB_PASS is the root password to set for the instance.
 "
 fi
 
+set -u
+set -o pipefail
+
 log=$(mktemp)
 
-db_conn_name=$(gcloud sql instances describe $db_instance \
-             | grep connectionName \
-             | sed 's/connectionName: //')
+instances=$(mktemp)
+gcloud sql instances describe $db_instance 2>$log >$instances \
+  || die "Failed to get description of Cloud SQL instance $db_instance: $(cat $log)"
+db_conn_name=$(grep connectionName $instances | sed 's/connectionName: //')
+if [[ $? != 0 ]]; then die "Failed to find connectionName in instance description."; fi
 db_host=":/cloudsql/$db_conn_name"
 echo "\
 <?php

appengine/standard/wordpress/update-wordpress

@@ -16,8 +16,8 @@ tar xzvf wordpress.tar.gz &>$log || die "Failed to untar wordpress tarball: $(ta
 curl -L https://github.com/wpCloud/wp-stateless/archive/2.1.1.tar.gz 2>$log >wp-stateless.tar.gz \
   || die "Failed to fetch wp-stateless plugin: $(cat $log)"
 tar xzvf wp-stateless.tar.gz &>$log || die "Failed to untar wp-stateless tarball: $(tail $log)"
-mv wp-stateless-2.1.1 wordpress/wp-content/plugins &>$log \
-  || die "Failed to move wp-stateless plugin into place: $(cat $log)"
+rsync wp-stateless-2.1.1 wordpress/wp-content/plugins &>$log \
+  || die "Failed to copy wp-stateless plugin into place: $(cat $log)"
 cd wordpress || die "Failed to cd into wordpress."
 # Force WordPress not to prepend ABSPATH to UPLOADS since we have
 # defined UPLOADS to be an absolute path: /tmp.