When debug is enabled, Netty ConnectListener erroneously consumes a retry token, close AsyncHttpClient#436

Author: Stephane Landelle

providers/netty/src/main/java/org/asynchttpclient/providers/netty/request/NettyConnectListener.java

@@ -74,8 +74,9 @@ public void onFutureSuccess(final Channel channel) throws ConnectException {
 
     public void onFutureFailure(Channel channel, Throwable cause) {
 
-        logger.debug("Trying to recover a dead cached channel {} with a retry value of {} ", channel, future.canRetry());
-        if (future.canRetry() && cause != null
+        boolean canRetry = future.canRetry();
+        logger.debug("Trying to recover a dead cached channel {} with a retry value of {} ", channel, canRetry);
+        if (canRetry && cause != null
                 && (NettyResponseFutures.abortOnDisconnectException(cause) || cause instanceof ClosedChannelException || future.getState() != NettyResponseFuture.STATE.NEW)) {
 
             logger.debug("Retrying {} ", future.getNettyRequest());