Introduce a constant exception for Remotely Closed

Author: Stephane Landelle

api/src/main/java/org/asynchttpclient/AsyncHttpClient.java

@@ -20,7 +20,9 @@
 import org.asynchttpclient.filter.FilterException;
 import org.asynchttpclient.filter.RequestFilter;
 import org.asynchttpclient.resumable.ResumableAsyncHandler;
+
 import java.io.Closeable;
+
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 

api/src/main/java/org/asynchttpclient/util/AsyncHttpProviderUtils.java

@@ -14,6 +14,7 @@
 
 import java.io.ByteArrayInputStream;
 import java.io.FileNotFoundException;
+import java.io.IOException;
 import java.io.InputStream;
 import java.io.SequenceInputStream;
 import java.io.UnsupportedEncodingException;
@@ -52,7 +53,13 @@
  * The cookies's handling code is from the Netty framework.
  */
 public class AsyncHttpProviderUtils {
-    
+
+    public static final IOException REMOTELY_CLOSED_EXCEPTION = new IOException("Remotely Closed");
+
+    static {
+        REMOTELY_CLOSED_EXCEPTION.setStackTrace(new StackTraceElement[] {});
+    }
+
     private final static byte[] NO_BYTES = new byte[0];
 
     public final static String DEFAULT_CHARSET = "ISO-8859-1";

api/src/test/java/org/asynchttpclient/async/AuthTimeoutTest.java

@@ -28,6 +28,7 @@
 import org.asynchttpclient.AsyncHttpClientConfig;
 import org.asynchttpclient.Realm;
 import org.asynchttpclient.Response;
+import org.asynchttpclient.util.AsyncHttpProviderUtils;
 import org.eclipse.jetty.server.Request;
 import org.eclipse.jetty.server.Server;
 import org.eclipse.jetty.server.handler.AbstractHandler;
@@ -195,7 +196,7 @@ public void digestFuturePreemptiveAuthTimeoutTest() throws Exception {
     protected void inspectException(Throwable t) {
         assertNotNull(t.getCause());
         assertEquals(t.getCause().getClass(), IOException.class);
-        if (!t.getCause().getMessage().startsWith("Remotely Closed")) {
+        if (t.getCause() != AsyncHttpProviderUtils.REMOTELY_CLOSED_EXCEPTION) {
             fail();
         }
     }

providers/grizzly/src/main/java/org/asynchttpclient/providers/grizzly/HttpTxContext.java

@@ -17,6 +17,7 @@
 import org.asynchttpclient.Request;
 import org.asynchttpclient.providers.grizzly.bodyhandler.BodyHandler;
 import org.asynchttpclient.providers.grizzly.statushandler.StatusHandler;
+import org.asynchttpclient.util.AsyncHttpProviderUtils;
 import org.asynchttpclient.websocket.WebSocket;
 import org.glassfish.grizzly.CloseListener;
 import org.glassfish.grizzly.CloseType;
@@ -67,7 +68,7 @@ public final class HttpTxContext {
         public void onClosed(Closeable closeable, CloseType type)
         throws IOException {
             if (CloseType.REMOTELY.equals(type)) {
-                abort(new IOException("Remotely Closed"));
+                abort(AsyncHttpProviderUtils.REMOTELY_CLOSED_EXCEPTION);
             }
         }
     };

providers/netty/src/main/java/org/asynchttpclient/providers/netty/handler/NettyChannelHandler.java

@@ -35,6 +35,7 @@
 import org.asynchttpclient.providers.netty.future.NettyResponseFuture;
 import org.asynchttpclient.providers.netty.future.NettyResponseFutures;
 import org.asynchttpclient.providers.netty.request.NettyRequestSender;
+import org.asynchttpclient.util.AsyncHttpProviderUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -119,7 +120,7 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
 
             if (future != null && !future.isDone() && !future.isCancelled()) {
                 if (!requestSender.retry(ctx.channel(), future)) {
-                    channels.abort(future, new IOException("Remotely Closed"));
+                    channels.abort(future, AsyncHttpProviderUtils.REMOTELY_CLOSED_EXCEPTION);
                 }
             } else {
                 channels.closeChannel(ctx);