Merged PR 22001: merge external changes

merge external changes

Author: ali-hamud

README.md

@@ -23,7 +23,7 @@ New [live demo](https://microsoft.github.io/PowerBI-JavaScript/demo) for sample
 
 Install via Nuget:
 
-`Install-Package Microsoft.PowerBI.JavaScript -Pre`
+`Install-Package Microsoft.PowerBI.JavaScript`
 
 Install from NPM:
 

demo/index.html

@@ -6,4 +6,4 @@
   <script>
 	window.location = "v2-demo/index.html";
   </script>
-</html>
+</html>

demo/v2-demo/docs.html

@@ -4,7 +4,7 @@ <h2>Getting Started</h2>
     </div>
     <div>
         Please visit our 
-        <a href="https://docs.microsoft.com/en-us/azure/power-bi-embedded/power-bi-embedded-what-is-power-bi-embedded">documentation</a>
+        <a href="https://powerbi.microsoft.com/en-us/documentation/powerbi-developer-embedding/">documentation</a>
         to start using Power BI Embedded.
     </div>
 </div>

demo/v2-demo/scripts/step_authorize.js

@@ -1,7 +1,7 @@
-var reportUrl = 'http://powerbilivedemobe.azurewebsites.net/api/Reports/SampleReport';
-var datasetUrl = 'http://powerbilivedemobe.azurewebsites.net/api/Reports/SampleCreate';
-var dashboardUrl = 'http://powerbilivedemobe.azurewebsites.net/api/Dashboards/SampleDashboard';
-var tileUrl = 'http://powerbilivedemobe.azurewebsites.net/api/Tiles/SampleTile';
+var reportUrl = 'https://powerbilivedemobe.azurewebsites.net/api/Reports/SampleReport';
+var datasetUrl = 'https://powerbilivedemobe.azurewebsites.net/api/Reports/SampleCreate';
+var dashboardUrl = 'https://powerbilivedemobe.azurewebsites.net/api/Dashboards/SampleDashboard';
+var tileUrl = 'https://powerbilivedemobe.azurewebsites.net/api/Tiles/SampleTile';
 
 var LastReportSampleUrl = null;
 var ReportRefreshTokenTimer = 0;

src/factories.ts

@@ -27,6 +27,7 @@ export const wpmpFactory: IWpmpFactory = (name?: string, logMessages?: boolean,
       getTrackingProperties: hpm.HttpPostMessage.getTrackingProperties,
     },
     isErrorMessage: hpm.HttpPostMessage.isErrorMessage,
+    suppressWarnings: true,
     name,
     logMessages,
     eventSourceOverrideWindow
@@ -35,4 +36,4 @@ export const wpmpFactory: IWpmpFactory = (name?: string, logMessages?: boolean,
 
 export const routerFactory: IRouterFactory = (wpmp) => {
   return new router.Router(wpmp);
-};
+};

src/service.ts

@@ -69,7 +69,7 @@ export class Service implements IService {
   /**
    * A list of components that this service can embed
    */
-   private static components: (typeof Report | typeof Tile | typeof Dashboard)[] = [
+  private static components: (typeof Report | typeof Tile | typeof Dashboard)[] = [
     Tile,
     Report,
     Dashboard
@@ -351,8 +351,8 @@ export class Service implements IService {
     const iframe = element.querySelector('iframe');
     if (iframe) {
       if(iframe.remove !== undefined) {
-          iframe.remove();
-	  }
+        iframe.remove();
+      }
       else {
           /** Workaround for IE: unhandled rejection TypeError: object doesn't support propert or method 'remove' */
           iframe.parentElement.removeChild(iframe);

tslint.json

@@ -1,9 +1,9 @@
 {
   "extends": "tslint:recommended",
   "rules": {
-    "max-line-length": false,
+    "max-line-length": [false],
     "member-access": false,
-    "no-console": false,
+    "no-console": [false],
     "one-line": [
       "check-whitespace",
       "check-open-brace"
@@ -12,7 +12,7 @@
       "single",
       "avoid-escape"
     ],
-    "trailing-comma": false,
+    "trailing-comma": [false],
     "whitespace": [
       "check-branch",
       "check-decl",