Skip to content

Commit ad4c4ac

Browse files
author
epriestley
committed
Break profiles less after D4376
Summary: This won't win any awards, but makes User and Project profile pages significantly less broken in the wake of D4376. Test Plan: {F28858} {F28859} Reviewers: btrahan, chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4382
1 parent f1d7c8f commit ad4c4ac

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

src/applications/people/controller/PhabricatorPeopleProfileController.php

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -130,9 +130,10 @@ public function processRequest() {
130130
}
131131
}
132132

133-
$header->appendChild($nav);
134-
$nav->appendChild(
135-
'<div style="padding: 1em;">'.$content.'</div>');
133+
$nav->appendChild($header);
134+
135+
$content = '<div style="padding: 1em;">'.$content.'</div>';
136+
$header->appendChild($content);
136137

137138
if ($user->getPHID() == $viewer->getPHID()) {
138139
$nav->addSpacer();
@@ -148,7 +149,7 @@ public function processRequest() {
148149
}
149150

150151
return $this->buildApplicationPage(
151-
$header,
152+
$nav,
152153
array(
153154
'title' => $user->getUsername(),
154155
));

src/applications/project/controller/PhabricatorProjectProfileController.php

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,6 @@ public function processRequest() {
6868
throw new Exception("Unimplemented filter '{$this->page}'.");
6969
}
7070

71-
$content = '<div style="padding: 1em;">'.$content.'</div>';
72-
$nav_view->appendChild($content);
7371

7472
$header = new PhabricatorProfileHeaderView();
7573
$header->setName($project->getName());
@@ -112,10 +110,13 @@ public function processRequest() {
112110

113111
$header->addAction($action);
114112

115-
$header->appendChild($nav_view);
113+
$nav_view->appendChild($header);
114+
115+
$content = '<div style="padding: 1em;">'.$content.'</div>';
116+
$header->appendChild($content);
116117

117118
return $this->buildStandardPageResponse(
118-
$header,
119+
$nav_view,
119120
array(
120121
'title' => $project->getName().' Project',
121122
));

0 commit comments

Comments
 (0)