Skip to content

Commit dfd6b1e

Browse files
TommertomTommertom
authored andcommitted
Removed typescript frmo svelte
1 parent b78d52e commit dfd6b1e

File tree

7 files changed

+47
-39
lines changed

7 files changed

+47
-39
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# Change Log Ionic-Svelte-NPM
22
All notable changes to this project will be documented in this file.
33

4+
## 0.62/63/64/65
5+
- removed typescript in *.svelte components as Vite does not process them (but does process *.ts)
6+
- removed IonTabsLegacy.svelte - can still be found here https://github.com/Tommertom/svelte-ionic-app/blob/main/src/IonTabsLegacy.svelte for manual inclusion
7+
48
## 0.5.60/61
59
- Put the NPM package with the demo app in one repo
610

components/IonNav.svelte

Lines changed: 28 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,35 @@
1-
<script lang="ts">
2-
import { onMount, type SvelteComponent } from "svelte";
1+
<script>
2+
import { onMount } from "svelte";
33
4-
export let root: any;
4+
/**
5+
* @typedef {Object} root: SvelteComponent;
6+
*/
7+
export let root;
8+
9+
/**
10+
* @typedef {Object} animated: boolean | undefined;
11+
*/
512
export let animated = true;
6-
export let animation: ((baseEl: any, opts?: any) => Animation) | undefined = undefined;
7-
export let rootParams: undefined | { [key: string]: any } = undefined;
8-
export let swipeGesture: boolean | undefined = undefined;
913
10-
//@ts-ignore - if we export ionNav, then the root element actually has access to ion-nav via this variable
11-
let ionNav: HTMLIonNavElement = undefined;
14+
/**
15+
* @typedef {Object} Animation: ((baseEl: any, opts?: any) => Animation) | undefined = undefined;
16+
*/
17+
export let animation; //
18+
19+
/**
20+
* @typedef {Object} rootParams: undefined | { [key: string]: any } = undefined;
21+
*/
22+
export let rootParams;
23+
24+
/**
25+
* @typedef {Object} swipeGesture: boolean | undefined = undefined;
26+
*/
27+
export let swipeGesture;
1228
13-
const createHTMLCompFromSvelte = (
14-
component: new (...args: any) => SvelteComponent,
15-
componentProps: { [key: string]: any } = {}
16-
) => {
29+
let ionNav;
30+
let rootComponent;
31+
32+
const createHTMLCompFromSvelte = (component, componentProps = {}) => {
1733
const divWrapper = document.createElement("div");
1834
const contentID = "id" + Date.now();
1935
divWrapper.id = contentID;
@@ -25,7 +41,6 @@
2541
2642
const props = {
2743
...componentProps,
28-
ionNav,
2944
};
3045
3146
const svelteComponent = new component({
@@ -36,10 +51,7 @@
3651
return divWrapper;
3752
};
3853
39-
let rootComponent: HTMLElement;
40-
4154
onMount(() => {
42-
//@ts-ignore
4355
rootComponent = createHTMLCompFromSvelte(root, {});
4456
});
4557
</script>

components/IonPage.svelte

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@
3232
});
3333
</script>
3434

35-
<div
36-
class="ion-page"
37-
in:fly={{ x: 1000, duration: 300 }}
38-
out:fly={{ x: -1000, duration: 300 }}
39-
>
35+
<div class="ion-page" in:fly={{ x: 1000, duration: 300 }} out:fly={{ x: -1000, duration: 300 }}>
4036
<slot />
4137
</div>

components/IonTabs.svelte

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<script lang="ts">
1+
<script>
22
import { onMount } from "svelte";
33
import { page } from "$app/stores";
44
@@ -8,15 +8,11 @@
88
export let ionTabsWillChange = () => {};
99
export let slot = "bottom";
1010
11-
let ionTabBarElement: HTMLIonTabsElement;
11+
let ionTabBarElement;
1212
13-
export let tabs: {
14-
label: string;
15-
icon: string;
16-
tab: string;
17-
}[] = [];
13+
export let tabs = [];
1814
19-
let controller: HTMLIonTabsElement;
15+
let controller;
2016
onMount(async () => {
2117
// reassignment needed after onMount
2218
controller = ionTabBarElement;
@@ -37,7 +33,7 @@
3733
}
3834
});
3935
40-
const tabBarClick = async (selectedTab: string) => {
36+
const tabBarClick = async (selectedTab) => {
4137
await goto(selectedTab);
4238
controller.select(selectedTab);
4339
};

demo-app/package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

demo-app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"type": "module",
4141
"dependencies": {
4242
"@ionic/core": "^6.5.3",
43-
"ionic-svelte": "^0.5.62",
43+
"ionic-svelte": "^0.5.66",
4444
"localforage": "^1.10.0"
4545
}
4646
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ionic-svelte",
3-
"version": "0.5.62",
3+
"version": "0.5.66",
44
"private": false,
55
"homepage": "https://ionicsvelte.firebaseapp.com",
66
"repository": {

0 commit comments

Comments
 (0)