Fix react-dates#625 - Rename AFTER_POSITION to ICON_AFTER_POSITION to be consistant + Use constant instead of string

Author: mariepw

constants.js

@@ -11,7 +11,7 @@ module.exports = {
   VERTICAL_SCROLLABLE: 'verticalScrollable',
 
   ICON_BEFORE_POSITION: 'before',
-  AFTER_POSITION: 'after',
+  ICON_AFTER_POSITION: 'after',
 
   ANCHOR_LEFT: 'left',
   ANCHOR_RIGHT: 'right',

src/components/DateRangePickerInput.jsx

@@ -14,7 +14,7 @@ import LeftArrow from '../svg/arrow-left.svg';
 import CloseButton from '../svg/close.svg';
 import CalendarIcon from '../svg/calendar.svg';
 
-import { START_DATE, END_DATE, ICON_BEFORE_POSITION } from '../../constants';
+import { START_DATE, END_DATE, ICON_BEFORE_POSITION, ICON_AFTER_POSITION } from '../../constants';
 
 const propTypes = forbidExtraProps({
   startDateId: PropTypes.string,
@@ -189,7 +189,7 @@ export default class DateRangePickerInput extends React.Component {
         })}
       >
 
-        { inputIconPosition === ICON_BEFORE_POSITION && inputIcon }
+        {inputIconPosition === ICON_BEFORE_POSITION && inputIcon}
 
         <DateInput
           id={startDateId}
@@ -257,7 +257,7 @@ export default class DateRangePickerInput extends React.Component {
           </button>
         )}
 
-        { inputIconPosition === 'after' && inputIcon }
+        {inputIconPosition === ICON_AFTER_POSITION && inputIcon}
 
       </div>
     );

src/components/SingleDatePickerInput.jsx

@@ -12,7 +12,7 @@ import IconPositionShape from '../shapes/IconPositionShape';
 import CloseButton from '../svg/close.svg';
 import CalendarIcon from '../svg/calendar.svg';
 
-import { ICON_BEFORE_POSITION } from '../../constants';
+import { ICON_BEFORE_POSITION, ICON_AFTER_POSITION } from '../../constants';
 
 const propTypes = forbidExtraProps({
   id: PropTypes.string.isRequired,
@@ -146,7 +146,7 @@ export default class SingleDatePickerInput extends React.Component {
         })}
       >
 
-        { inputIconPosition === ICON_BEFORE_POSITION && inputIcon }
+        {inputIconPosition === ICON_BEFORE_POSITION && inputIcon}
 
         <DateInput
           id={id}
@@ -185,7 +185,7 @@ export default class SingleDatePickerInput extends React.Component {
           </button>
         )}
 
-        { inputIconPosition === 'after' && inputIcon }
+        {inputIconPosition === ICON_AFTER_POSITION && inputIcon}
 
       </div>
     );

src/shapes/IconPositionShape.js

@@ -2,7 +2,7 @@ import PropTypes from 'prop-types';
 
 import {
   ICON_BEFORE_POSITION,
-  AFTER_POSITION,
+  ICON_AFTER_POSITION,
 } from '../../constants';
 
-export default PropTypes.oneOf([ICON_BEFORE_POSITION, AFTER_POSITION]);
+export default PropTypes.oneOf([ICON_BEFORE_POSITION, ICON_AFTER_POSITION]);