Stub out save as option for nbagg figure

Author: blink1073

lib/matplotlib/backends/backend_nbagg.py

@@ -92,6 +92,7 @@ def connection_info():
     'forward': 'fa fa-arrow-right icon-arrow-right',
     'zoom_to_rect': 'fa fa-square-o icon-check-empty',
     'move': 'fa fa-arrows icon-move',
+    'download': 'fa fa-icon-save icon-save',
     None: None
 }
 
@@ -102,7 +103,8 @@ class NavigationIPy(NavigationToolbar2WebAgg):
     toolitems = [(text, tooltip_text,
                   _FONT_AWESOME_CLASSES[image_file], name_of_method)
                  for text, tooltip_text, image_file, name_of_method
-                 in NavigationToolbar2.toolitems
+                 in (NavigationToolbar2.toolitems +
+                     (('Download', 'Download plot', 'download', 'download'),))
                  if image_file in _FONT_AWESOME_CLASSES]
 
 

lib/matplotlib/backends/web_backend/mpl.js

@@ -472,8 +472,12 @@ mpl.figure.prototype.key_event = function(event, name) {
 
 mpl.figure.prototype.toolbar_button_onclick = function(name) {
     if (name == 'download') {
-        var format_dropdown = this.format_dropdown;
-        var format = format_dropdown.options[format_dropdown.selectedIndex].value;
+        if (this.format_dropdown) {
+            var format_dropdown = this.format_dropdown;
+            var format = format_dropdown.options[format_dropdown.selectedIndex].value;
+        } else {
+            format = 'png';
+        }
         this.ondownload(this, format);
     } else {
         this.send_message("toolbar_button", {name: name});

lib/matplotlib/backends/web_backend/nbagg_mpl.js

@@ -30,8 +30,12 @@ mpl.mpl_figure_comm = function(comm, msg) {
     var element = $("#" + id);
     var ws_proxy = comm_websocket_adapter(comm)
 
+    function ondownload(figure, format) {
+        window.location.href = 'hello.' + format
+    }
+
     var fig = new mpl.figure(id, ws_proxy,
-                           function() { },
+                           ondownload,
                            element.get(0));
 
     // Call onopen now - mpl needs it, as it is assuming we've passed it a real