minor optim: only compute isConnectDone when necessary

Author: slandelle

client/src/main/java/org/asynchttpclient/netty/request/NettyRequestSender.java

@@ -89,23 +89,27 @@ public <T> ListenableFuture<T> sendRequest(final Request request,//
         validateWebSocketRequest(request, asyncHandler);
 
         ProxyServer proxyServer = getProxyServer(config, request);
-        boolean connectIsDone = future != null //
-                && future.getNettyRequest() != null //
-                && future.getNettyRequest().getHttpRequest().getMethod() == HttpMethod.CONNECT //
-                && !request.getMethod().equals(HttpMethod.CONNECT.name());
 
         // websockets use connect tunnelling to work with proxies
-        if (proxyServer != null && (request.getUri().isSecured() || request.getUri().isWebSocket()) && !connectIsDone)
-            // SSL proxy or websocket, have to handle CONNECT
+        if (proxyServer != null && (request.getUri().isSecured() || request.getUri().isWebSocket()) && !isConnectDone(request, future))
             if (future != null && future.isConnectAllowed())
-                // CONNECT forced
+                // SSL proxy or websocket: CONNECT for sure
                 return sendRequestWithCertainForceConnect(request, asyncHandler, future, reclaimCache, proxyServer, true);
             else
+                // CONNECT will depend if we can pool or connection or if we have to open a new one
                 return sendRequestThroughSslProxy(request, asyncHandler, future, reclaimCache, proxyServer);
         else
+            // no CONNECT for sure
             return sendRequestWithCertainForceConnect(request, asyncHandler, future, reclaimCache, proxyServer, false);
     }
 
+    private boolean isConnectDone(Request request,NettyResponseFuture<?> future) {
+        return future != null //
+                && future.getNettyRequest() != null //
+                && future.getNettyRequest().getHttpRequest().getMethod() == HttpMethod.CONNECT //
+                && !request.getMethod().equals(HttpMethod.CONNECT.name());
+    }
+
     /**
      * We know for sure if we have to force to connect or not, so we can build
      * the HttpRequest right away This reduces the probability of having a
@@ -211,7 +215,7 @@ private <T> ListenableFuture<T> sendRequestWithOpenChannel(Request request, Prox
         future.setChannelState(ChannelState.POOLED);
         future.attachChannel(channel, false);
 
-        LOGGER.debug("Using cached Channel {} for {} '{}'", channel, future.getNettyRequest().getHttpRequest().getMethod(), future.getNettyRequest().getHttpRequest().getUri());
+        LOGGER.debug("Using open Channel {} for {} '{}'", channel, future.getNettyRequest().getHttpRequest().getMethod(), future.getNettyRequest().getHttpRequest().getUri());
 
         if (Channels.isChannelValid(channel)) {
             Channels.setAttribute(channel, future);
@@ -452,7 +456,7 @@ private Channel pollPooledChannel(Request request, ProxyServer proxy, AsyncHandl
         final Channel channel = channelManager.poll(uri, virtualHost, proxy, request.getConnectionPoolPartitioning());
 
         if (channel != null) {
-            LOGGER.debug("Using cached Channel {}\n for uri {}\n", channel, uri);
+            LOGGER.debug("Using polled Channel {}\n for uri {}\n", channel, uri);
         }
         return channel;
     }