Skip to content

Commit 1ce4c86

Browse files
committed
Refactored SpiderLoader class constructor for easier subclassing
1 parent 84dea19 commit 1ce4c86

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

scrapy/spiderloader.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,17 @@ class SpiderLoader(object):
1717
def __init__(self, settings):
1818
self.spider_modules = settings.getlist('SPIDER_MODULES')
1919
self._spiders = {}
20-
for name in self.spider_modules:
21-
for module in walk_modules(name):
22-
self._load_spiders(module)
23-
20+
self._load_all_spiders()
21+
2422
def _load_spiders(self, module):
2523
for spcls in iter_spider_classes(module):
2624
self._spiders[spcls.name] = spcls
2725

26+
def _load_all_spiders(self):
27+
for name in self.spider_modules:
28+
for module in walk_modules(name):
29+
self._load_spiders(module)
30+
2831
@classmethod
2932
def from_settings(cls, settings):
3033
return cls(settings)

0 commit comments

Comments
 (0)