Skip to content

Commit 6cbe684

Browse files
committed
do no include ResponseFailed if http11 handler is not enabled
1 parent 1a20bba commit 6cbe684

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

scrapy/tests/test_downloadermiddleware_retry.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import unittest
2-
32
from twisted.internet.error import TimeoutError as ServerTimeoutError, \
43
DNSLookupError, ConnectionRefusedError, ConnectionDone, ConnectError, \
54
ConnectionLost
65

6+
from scrapy import optional_features
77
from scrapy.contrib.downloadermiddleware.retry import RetryMiddleware
88
from scrapy.xlib.tx import ResponseFailed
99
from scrapy.spider import BaseSpider
@@ -64,9 +64,13 @@ def test_503(self):
6464
assert self.mw.process_response(req, rsp, self.spider) is rsp
6565

6666
def test_twistederrors(self):
67-
for exc in (ServerTimeoutError, DNSLookupError, ConnectionRefusedError,
68-
ConnectionDone, ConnectError, ConnectionLost,
69-
ResponseFailed):
67+
exceptions = [ServerTimeoutError, DNSLookupError,
68+
ConnectionRefusedError, ConnectionDone, ConnectError,
69+
ConnectionLost]
70+
if 'http11' in optional_features:
71+
exceptions.append(ResponseFailed)
72+
73+
for exc in exceptions:
7074
req = Request('http://www.scrapytest.org/%s' % exc.__name__)
7175
self._test_retry_exception(req, exc('foo'))
7276

0 commit comments

Comments
 (0)