Skip to content

Commit 7717501

Browse files
committed
Use log formatting and pass crawler reference
1 parent eb44152 commit 7717501

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

scrapy/core/downloader/handlers/__init__.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
class DownloadHandlers(object):
1616

1717
def __init__(self, crawler):
18-
self._crawler_settings = crawler.settings
18+
self._crawler = crawler
1919
self._schemes = {} # stores acceptable schemes on instancing
2020
self._handlers = {} # stores instanced handlers for schemes
2121
self._notconfigured = {} # remembers failed handlers
@@ -45,13 +45,14 @@ def _get_handler(self, scheme):
4545
path = self._schemes[scheme]
4646
try:
4747
dhcls = load_object(path)
48-
dh = dhcls(self._crawler_settings)
48+
dh = dhcls(self._crawler.settings)
4949
except NotConfigured as ex:
5050
self._notconfigured[scheme] = str(ex)
5151
return None
5252
except Exception as ex:
53-
logger.exception('Loading "{}" for scheme "{}" handler'
54-
.format(path, scheme))
53+
logger.error('Loading "%(clspath)s" for scheme "%(scheme)s"',
54+
{"clspath": path, "scheme": scheme},
55+
exc_info=True, extra={'crawler': self._crawler})
5556
self._notconfigured[scheme] = str(ex)
5657
return None
5758
else:

0 commit comments

Comments
 (0)