Skip to content

Commit 0714f6e

Browse files
committed
Safeguard findUniqueFilename from race conditions
This might partially, but not fully, solve Issue commons-app#228 (accidental overwriting).
1 parent 1bdcf3f commit 0714f6e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

app/src/main/java/fr/free/nrw/commons/upload/UploadService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ private void showFailedNotification(Contribution contribution) {
284284
contribution.save();
285285
}
286286

287-
private String findUniqueFilename(String fileName) throws IOException {
287+
synchronized private String findUniqueFilename(String fileName) throws IOException {
288288
return findUniqueFilename(fileName, 1);
289289
}
290290

0 commit comments

Comments
 (0)