Skip to content

Commit c92c471

Browse files
authored
Fix after model validator signatures (apache#2626)
<!-- Thanks for opening a pull request! --> <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> # Rationale for this change (Partially?) fixes apache#2590. See https://pydantic.dev/articles/pydantic-v2-12-release#after-model-validators. ## Are these changes tested? ## Are there any user-facing changes? <!-- In the case of user-facing changes, please add the changelog label. -->
1 parent 617e258 commit c92c471

File tree

1 file changed

+18
-18
lines changed

1 file changed

+18
-18
lines changed

pyiceberg/table/metadata.py

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -363,8 +363,8 @@ def cleanup_snapshot_id(cls, data: Dict[str, Any]) -> Dict[str, Any]:
363363
return cleanup_snapshot_id(data)
364364

365365
@model_validator(mode="after")
366-
def construct_refs(cls, data: TableMetadataV1) -> TableMetadataV1:
367-
return construct_refs(data)
366+
def construct_refs(self) -> TableMetadataV1:
367+
return construct_refs(self)
368368

369369
@model_validator(mode="before")
370370
def set_v2_compatible_defaults(cls, data: Dict[str, Any]) -> Dict[str, Any]:
@@ -492,20 +492,20 @@ def cleanup_snapshot_id(cls, data: Dict[str, Any]) -> Dict[str, Any]:
492492
return cleanup_snapshot_id(data)
493493

494494
@model_validator(mode="after")
495-
def check_schemas(cls, table_metadata: TableMetadata) -> TableMetadata:
496-
return check_schemas(table_metadata)
495+
def check_schemas(self) -> TableMetadata:
496+
return check_schemas(self)
497497

498498
@model_validator(mode="after")
499-
def check_partition_specs(cls, table_metadata: TableMetadata) -> TableMetadata:
500-
return check_partition_specs(table_metadata)
499+
def check_partition_specs(self) -> TableMetadata:
500+
return check_partition_specs(self)
501501

502502
@model_validator(mode="after")
503-
def check_sort_orders(cls, table_metadata: TableMetadata) -> TableMetadata:
504-
return check_sort_orders(table_metadata)
503+
def check_sort_orders(self) -> TableMetadata:
504+
return check_sort_orders(self)
505505

506506
@model_validator(mode="after")
507-
def construct_refs(cls, table_metadata: TableMetadata) -> TableMetadata:
508-
return construct_refs(table_metadata)
507+
def construct_refs(self) -> TableMetadata:
508+
return construct_refs(self)
509509

510510
format_version: Literal[2] = Field(alias="format-version", default=2)
511511
"""An integer version number for the format. Implementations must throw
@@ -536,20 +536,20 @@ def cleanup_snapshot_id(cls, data: Dict[str, Any]) -> Dict[str, Any]:
536536
return cleanup_snapshot_id(data)
537537

538538
@model_validator(mode="after")
539-
def check_schemas(cls, table_metadata: TableMetadata) -> TableMetadata:
540-
return check_schemas(table_metadata)
539+
def check_schemas(self) -> TableMetadata:
540+
return check_schemas(self)
541541

542542
@model_validator(mode="after")
543-
def check_partition_specs(cls, table_metadata: TableMetadata) -> TableMetadata:
544-
return check_partition_specs(table_metadata)
543+
def check_partition_specs(self) -> TableMetadata:
544+
return check_partition_specs(self)
545545

546546
@model_validator(mode="after")
547-
def check_sort_orders(cls, table_metadata: TableMetadata) -> TableMetadata:
548-
return check_sort_orders(table_metadata)
547+
def check_sort_orders(self) -> TableMetadata:
548+
return check_sort_orders(self)
549549

550550
@model_validator(mode="after")
551-
def construct_refs(cls, table_metadata: TableMetadata) -> TableMetadata:
552-
return construct_refs(table_metadata)
551+
def construct_refs(self) -> TableMetadata:
552+
return construct_refs(self)
553553

554554
format_version: Literal[3] = Field(alias="format-version", default=3)
555555
"""An integer version number for the format. Implementations must throw

0 commit comments

Comments
 (0)