Fix additional "xprintf()"-class static parameter lint errors

Summary: Ref T13577. After the fix in D21453, lint identifies additional static errors in Phabricator; fix them.

Test Plan: Ran `arc lint`; these messages are essentially all very obscure.

Subscribers: hach-que, yelirekim, PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13577

Differential Revision: https://secure.phabricator.com/D21457

Author: epriestley

resources/sql/autopatches/20150602.mlist.2.php

@@ -40,7 +40,8 @@
   if (!$username_okay) {
     echo pht(
       'Failed to migrate mailing list "%s": unable to generate a unique '.
-      'username for it.')."\n";
+      'username for it.',
+      $name)."\n";
     continue;
   }
 

src/applications/differential/management/PhabricatorDifferentialRebuildChangesetsWorkflow.php

@@ -36,7 +36,8 @@ public function execute(PhutilArgumentParser $args) {
         throw new PhutilArgumentUsageException(
           pht(
             'Object "%s" specified by "--revision" must be a Differential '.
-            'revision.'));
+            'revision.',
+            $revision_identifier));
       }
     } else {
       $revision = id(new DifferentialRevisionQuery())

src/applications/differential/xaction/DifferentialRevisionRepositoryTransaction.php

@@ -84,7 +84,8 @@ public function validateTransactions($object, array $xactions) {
         $errors[] = $this->newInvalidError(
           pht(
             'Repository "%s" is not a valid repository, or you do not have '.
-            'permission to view it.'),
+            'permission to view it.',
+            $new_value),
           $xaction);
       }
     }

src/applications/fact/chart/PhabricatorChartFunctionArgumentParser.php

@@ -43,6 +43,7 @@ public function addArgument(PhabricatorChartFunctionArgument $spec) {
         pht(
           'Chart function "%s" emitted an argument specification ("%s") with '.
           'no type. Each argument specification must have a valid type.',
+          $this->getFunctionArgumentSignature(),
           $name));
     }
 

src/applications/harbormaster/management/HarbormasterManagementPublishWorkflow.php

@@ -54,6 +54,7 @@ public function execute(PhutilArgumentParser $args) {
           pht(
             'Object "%s" is not a HarbormasterBuildable (it is a "%s"). '.
             'Name one or more buildables to publish, like "B123".',
+            $name,
             get_class($result)));
       }
     }

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

@@ -177,6 +177,8 @@ public function loadData($offset, $length) {
         pht(
           'Attempt to load log bytes (%d - %d) failed: failed to '.
           'load a single contiguous range. Actual ranges: %s.',
+          $offset,
+          $end,
           implode('; ', $display_ranges)));
     }
 

src/applications/maniphest/constants/ManiphestTaskPriority.php

@@ -199,8 +199,7 @@ public static function validateConfiguration($config) {
       throw new Exception(
         pht(
           'Configuration is not valid. Maniphest priority configurations '.
-          'must be dictionaries.',
-          $config));
+          'must be dictionaries.'));
     }
 
     $all_keywords = array();

src/applications/metamta/adapter/PhabricatorMailAdapter.php

@@ -65,6 +65,7 @@ final public function setMedia(array $media) {
           pht(
             'Adapter ("%s") is configured for medium "%s", but this is not '.
             'a supported delivery medium. Supported media are: %s.',
+            get_class($this),
             $medium,
             implode(', ', $native_map)));
       }

src/applications/notification/config/PhabricatorNotificationServersConfigType.php

@@ -98,7 +98,9 @@ public function validateStoredValue(
             'Notification server configuration describes an invalid host '.
             '("%s", at index "%s"). This is an "admin" service but it has a '.
             '"path" property. This property is only valid for "client" '.
-            'services.'));
+            'services.',
+            $host,
+            $index));
       }
 
       // We can't guarantee that you didn't just give the same host two

src/applications/nuance/github/__tests__/NuanceGitHubRawEventTestCase.php

@@ -85,7 +85,8 @@ private function readTestCases($path) {
         throw new Exception(
           pht(
             'Expected test file "%s" to contain exactly two sections, '.
-            'but it has more than two sections.'));
+            'but it has more than two sections.',
+            $file));
       }
 
       list($input, $expect) = $parts;