Skip to content

Commit 15021a0

Browse files
author
epriestley
committed
Fix bad array index test in Differential package code
Summary: This needs an `isset()` for cases when authority and packages don't completely overlap. Test Plan: - With a package set to trigger autoreview, created a revision. - Observed error log, saw no more error. - Saw package trigger autoreview properly. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D16398
1 parent 8c41226 commit 15021a0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/applications/differential/editor/DifferentialTransactionEditor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1533,7 +1533,7 @@ protected function didApplyHeraldRules(
15331533

15341534
foreach ($packages as $key => $package) {
15351535
$package_phid = $package->getPHID();
1536-
if ($authority[$package_phid]) {
1536+
if (isset($authority[$package_phid])) {
15371537
unset($packages[$key]);
15381538
continue;
15391539
}

0 commit comments

Comments
 (0)