Skip to content

Commit 1ecce60

Browse files
author
epriestley
committed
Keep setIcon() working for now on PHUIObjectItemView
Summary: Ref T11501. This method was removed in D16418, but still has some callsites. I know of four: - Config - Settings - Drydock main page - Almanac main page Since I might be missing some and it's close to the release cut, just put the method back for now until we can clean it up more properly. Test Plan: Viewed Settings, Config, Drydock, Almanac. No more fatal on this method being missing. Reviewers: chad Reviewed By: chad Maniphest Tasks: T11501 Differential Revision: https://secure.phabricator.com/D16420
1 parent 1cca7fb commit 1ecce60

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/view/phui/PHUIObjectItemView.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,11 @@ public function addIcon($icon, $label = null, $attributes = array()) {
167167
return $this;
168168
}
169169

170+
public function setIcon($icon) {
171+
// TODO: Remove this in favor of setStatusIcon()?
172+
return $this->setStatusIcon($icon);
173+
}
174+
170175
public function setStatusIcon($icon, $label = null) {
171176
$this->statusIcon = array(
172177
'icon' => $icon,

0 commit comments

Comments
 (0)