Provide an "--output" mode for "bin/storage dump" with better error handling

Summary:
Ref T6996. If you do this kind of thing in the shell, you don't get a good error by default if the `dump` command fails:

```
$ bin/storage dump | gzip > output.sql.gz
```

This can be worked around with some elaborate bash tricks, but they're really clunky and uninintuitive.

We also need to do this in several places (while writing backups; while performing exports), and I don't want to copy clunky bash tricks all over the codebase.

Instead, provide `--output` and `--compress` flags which just do this processing inside `bin/storage dump`. It will fail appropriately if any of the underlying operations fail. This also makes the write a little safer (refuses to overwrite) and the code more reusable.

Test Plan:
  - Did three dumps, with no flags, `--output`, and `--output --compress`.
  - Verified all three took similar amounts of time and were identical except for "Date Exported" timestamps in comments (except that the compressed one was compressed).
  - Used `gunzip` to examine the compressed one, verified it was really compressed.
  - Faked a write error, saw properly command behavior (clean up file + exit with error).

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T6996

Differential Revision: https://secure.phabricator.com/D16407

Author: epriestley

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php

@@ -16,6 +16,26 @@ protected function didConstruct() {
               'Add __--master-data__ to the __mysqldump__ command, '.
               'generating a CHANGE MASTER statement in the output.'),
           ),
+          array(
+            'name' => 'output',
+            'param' => 'file',
+            'help' => pht(
+              'Write output directly to disk. This handles errors better '.
+              'than using pipes. Use with __--compress__ to gzip the '.
+              'output.'),
+          ),
+          array(
+            'name' => 'compress',
+            'help' => pht(
+              'With __--output__, write a compressed file to disk instead '.
+              'of a plaintext file.'),
+          ),
+          array(
+            'name' => 'overwrite',
+            'help' => pht(
+              'With __--output__, overwrite the output file if it already '.
+              'exists.'),
+          ),
         ));
   }
 
@@ -55,6 +75,38 @@ public function didExecute(PhutilArgumentParser $args) {
       }
     }
 
+    $output_file = $args->getArg('output');
+    $is_compress = $args->getArg('compress');
+    $is_overwrite = $args->getArg('overwrite');
+
+    if ($is_compress) {
+      if ($output_file === null) {
+        throw new PhutilArgumentUsageException(
+          pht(
+            'The "--compress" flag can only be used alongside "--output".'));
+      }
+    }
+
+    if ($is_overwrite) {
+      if ($output_file === null) {
+        throw new PhutilArgumentUsageException(
+          pht(
+            'The "--overwrite" flag can only be used alongside "--output".'));
+      }
+    }
+
+    if ($output_file !== null) {
+      if (Filesystem::pathExists($output_file)) {
+        if (!$is_overwrite) {
+          throw new PhutilArgumentUsageException(
+            pht(
+              'Output file "%s" already exists. Use "--overwrite" '.
+              'to overwrite.',
+              $output_file));
+        }
+      }
+    }
+
     $argv = array();
     $argv[] = '--hex-blob';
     $argv[] = '--single-transaction';
@@ -79,13 +131,83 @@ public function didExecute(PhutilArgumentParser $args) {
       $argv[] = $database;
     }
 
+
     if ($has_password) {
-      $err = phutil_passthru('mysqldump -p%P %Ls', $password, $argv);
+      $command = csprintf('mysqldump -p%P %Ls', $password, $argv);
+    } else {
+      $command = csprintf('mysqldump %Ls', $argv);
+    }
+
+    // If we aren't writing to a file, just passthru the command.
+    if ($output_file === null) {
+      return phutil_passthru('%C', $command);
+    }
+
+    // If we are writing to a file, stream the command output to disk. This
+    // mode makes sure the whole command fails if there's an error (commonly,
+    // a full disk). See T6996 for discussion.
+
+    if ($is_compress) {
+      $file = gzopen($output_file, 'wb');
     } else {
-      $err = phutil_passthru('mysqldump %Ls', $argv);
+      $file = fopen($output_file, 'wb');
+    }
+
+    if (!$file) {
+      throw new Exception(
+        pht(
+          'Failed to open file "%s" for writing.',
+          $file));
+    }
+
+    $future = new ExecFuture('%C', $command);
+
+    $lines = new LinesOfALargeExecFuture($future);
+
+    try {
+      foreach ($lines as $line) {
+        $line = $line."\n";
+        if ($is_compress) {
+          $ok = gzwrite($file, $line);
+        } else {
+          $ok = fwrite($file, $line);
+        }
+
+        if ($ok !== strlen($line)) {
+          throw new Exception(
+            pht(
+              'Failed to write %d byte(s) to file "%s".',
+              new PhutilNumber(strlen($line)),
+              $output_file));
+        }
+      }
+
+      if ($is_compress) {
+        $ok = gzclose($file);
+      } else {
+        $ok = fclose($file);
+      }
+
+      if ($ok !== true) {
+        throw new Exception(
+          pht(
+            'Failed to close file "%s".',
+            $output_file));
+      }
+    } catch (Exception $ex) {
+      // If we might have written a partial file to disk, try to remove it so
+      // we don't leave any confusing artifacts laying around.
+
+      try {
+        Filesystem::remove($output_file);
+      } catch (Exception $ex) {
+        // Ignore any errors we hit.
+      }
+
+      throw $ex;
     }
 
-    return $err;
+    return 0;
   }
 
 }