HardwareDevices: Remove disk attribute description

Author: dmex

plugins/HardwareDevices/HardwareDevices.rc

@@ -180,9 +180,7 @@ STYLE DS_SETFONT | DS_MODALFRAME | DS_FIXEDSYS | WS_POPUP | WS_CAPTION | WS_SYSM
 CAPTION "SMART"
 FONT 8, "MS Shell Dlg", 400, 0, 0x1
 BEGIN
-    CONTROL         "",IDC_DETAILS_LIST,"SysListView32",LVS_REPORT | LVS_ALIGNLEFT | WS_BORDER | WS_TABSTOP,0,1,309,193
-    EDITTEXT        IDC_EDIT1,0,207,309,58,ES_MULTILINE | ES_READONLY | WS_VSCROLL
-    LTEXT           "Description:",IDC_DESCRIPTION,0,196,39,8
+    CONTROL         "",IDC_DETAILS_LIST,"SysListView32",LVS_REPORT | LVS_ALIGNLEFT | WS_BORDER | WS_TABSTOP,0,1,309,264
 END
 
 IDD_DISKDRIVE_DETAILS_FILESYSTEM DIALOGEX 0, 0, 309, 265

plugins/HardwareDevices/devices.h

@@ -846,10 +846,6 @@ PWSTR SmartAttributeGetText(
     _In_ SMART_ATTRIBUTE_ID AttributeId
     );
 
-PWSTR SmartAttributeGetDescription(
-    _In_ SMART_ATTRIBUTE_ID AttributeId
-    );
-
 // diskgraph.c
 
 VOID DiskDriveSysInfoInitializing(

plugins/HardwareDevices/diskdetails.c

@@ -696,32 +696,12 @@ INT_PTR CALLBACK DiskDriveSmartDetailsDlgProc(
 
                 dialogItem = PvAddPropPageLayoutItem(hwndDlg, hwndDlg, PH_PROP_PAGE_TAB_CONTROL_PARENT, PH_ANCHOR_ALL);
                 PvAddPropPageLayoutItem(hwndDlg, context->ListViewHandle, dialogItem, PH_ANCHOR_ALL);
-                PvAddPropPageLayoutItem(hwndDlg, GetDlgItem(hwndDlg, IDC_DESCRIPTION), dialogItem, PH_ANCHOR_LEFT | PH_ANCHOR_BOTTOM | PH_ANCHOR_RIGHT);
-                PvAddPropPageLayoutItem(hwndDlg, GetDlgItem(hwndDlg, IDC_EDIT1), dialogItem, PH_ANCHOR_LEFT | PH_ANCHOR_BOTTOM | PH_ANCHOR_RIGHT);
-
                 PvDoPropPageLayout(hwndDlg);
 
                 propPageContext->LayoutInitialized = TRUE;
             }
         }
         break;
-    case WM_NOTIFY:
-        {
-            LPNMHDR header = (LPNMHDR)lParam;
-
-            if (header->code == LVN_ITEMCHANGED)
-            {
-                PWSTR description;
-
-                if (ListView_GetSelectedCount(context->ListViewHandle) == 1)
-                    description = SmartAttributeGetDescription((SMART_ATTRIBUTE_ID)PhGetSelectedListViewItemParam(context->ListViewHandle));
-                else
-                    description = L"";
-
-                SetDlgItemText(hwndDlg, IDC_EDIT1, description);
-            }
-        }
-        break;
     }
 
     return FALSE;
@@ -767,6 +747,7 @@ NTSTATUS ShowDiskDriveDetailsDialogThread(
         PhModalPropertySheet(&propContext->PropSheetHeader);
         PhDereferenceObject(propContext);
     }
+
     return STATUS_SUCCESS;
 }
 

plugins/HardwareDevices/resource.h

@@ -21,11 +21,9 @@
 #define IDC_SHOW_HIDDEN_ADAPTERS        1012
 #define IDD_DISKDRIVE_OPTIONS           1013
 #define IDD_DISKDRIVE_DIALOG            1014
-#define IDC_EDIT1                       1015
 #define IDD_DISKDRIVE_PANEL             1016
 #define IDD_DISKDRIVE_DETAILS_SMART     1017
 #define IDC_DISKDRIVE_LISTVIEW          1017
-#define IDC_DESCRIPTION                 1017
 #define IDC_DISKMOUNTPATH               1018
 #define IDC_STAT_BREAD                  1020
 #define IDC_STAT_BWRITE                 1021

plugins/HardwareDevices/storage.c

@@ -1501,134 +1501,5 @@ PWSTR SmartAttributeGetText(
         return L"Free Fall Protection";
     }
 
-    return L"Unknown";
-}
-
-PWSTR SmartAttributeGetDescription(
-    _In_ SMART_ATTRIBUTE_ID AttributeId
-    )
-{
-    // https://en.wikipedia.org/wiki/S.M.A.R.T
-
-    switch (AttributeId)
-    {
-    case SMART_ATTRIBUTE_ID_READ_ERROR_RATE:
-        return L"Lower raw value is better.\r\nVendor specific raw value. Stores data related to the rate of hardware read errors that occurred when reading data from a disk surface. The raw value has different structure for different vendors and is often not meaningful as a decimal number.";
-    case SMART_ATTRIBUTE_ID_THROUGHPUT_PERFORMANCE:
-        return L"Higher raw value is better.\r\nOverall (general) throughput performance of a hard disk drive. If the value of this attribute is decreasing there is a high probability that there is a problem with the disk.";
-    case SMART_ATTRIBUTE_ID_SPIN_UP_TIME:
-        return L"Lower raw value is better.\r\nAverage time of spindle spin up (from zero RPM to fully operational [milliseconds]).";
-    case SMART_ATTRIBUTE_ID_START_STOP_COUNT:
-        return L"A tally of spindle start/stop cycles.\r\nThe spindle turns on, and hence the count is increased, both when the hard disk is turned on after having before been turned entirely off (disconnected from power source) and when the hard disk returns from having previously been put to sleep mode.";
-    case SMART_ATTRIBUTE_ID_REALLOCATED_SECTORS_COUNT:
-        return L"Lower raw value is better.\r\nCount of reallocated sectors. When the hard drive finds a read/write/verification error, it marks that sector as \"reallocated\" and transfers data to a special reserved area (spare area). This process is also known as remapping, and reallocated sectors are called \"remaps\". The raw value normally represents a count of the bad sectors that have been found and remapped. Thus, the higher the attribute value, the more sectors the drive has had to reallocate. This allows a drive with bad sectors to continue operation; however, a drive which has had any reallocations at all is significantly more likely to fail in the near future. While primarily used as a metric of the life expectancy of the drive, this number also affects performance. As the count of reallocated sectors increases, the read/write speed tends to become worse because the drive head is forced to seek to the reserved area whenever a remap is accessed. If sequential access speed is critical, the remapped sectors can be manually marked as bad blocks in the file system in order to prevent their use.";
-    case SMART_ATTRIBUTE_ID_READ_CHANNEL_MARGIN:
-        return L"Margin of a channel while reading data.\r\nThe function of this attribute is not specified.";
-    case SMART_ATTRIBUTE_ID_SEEK_ERROR_RATE:
-        return L"Vendor specific raw value.\r\nRate of seek errors of the magnetic heads. If there is a partial failure in the mechanical positioning system, then seek errors will arise. Such a failure may be due to numerous factors, such as damage to a servo, or thermal widening of the hard disk. The raw value has different structure for different vendors and is often not meaningful as a decimal number.";
-    case SMART_ATTRIBUTE_ID_SEEK_TIME_PERFORMANCE:
-        return L"Average performance of seek operations of the magnetic heads.\r\nIf this attribute is decreasing, it is a sign of problems in the mechanical subsystem.";
-    case SMART_ATTRIBUTE_ID_POWER_ON_HOURS:
-        return L"Count of hours in power-on state.\r\nThe raw value of this attribute shows total count of hours (or minutes, or seconds, depending on manufacturer) in power-on state.\r\nBy default, the total expected lifetime of a hard disk in perfect condition is defined as 5 years(running every day and night on all days).This is equal to 1825 days in 24 / 7 mode or 43800 hours.\r\nOn some pre-2005 drives, this raw value may advance erratically and/or \"wrap around\" (reset to zero periodically).";
-    case SMART_ATTRIBUTE_ID_SPIN_RETRY_COUNT:
-        return L"Count of retry of spin start attempts.\r\nThis attribute stores a total count of the spin start attempts to reach the fully operational speed (under the condition that the first attempt was unsuccessful). An increase of this attribute value is a sign of problems in the hard disk mechanical subsystem.";
-    case SMART_ATTRIBUTE_ID_CALIBRATION_RETRY_COUNT:
-        return L"This attribute indicates the count that recalibration was requested (under the condition that the first attempt was unsuccessful). An increase of this attribute value is a sign of problems in the hard disk mechanical subsystem.";
-    case SMART_ATTRIBUTE_ID_POWER_CYCLE_COUNT:
-        return L"This attribute indicates the count of full hard disk power on/off cycles.";
-    case SMART_ATTRIBUTE_ID_SOFT_READ_ERROR_RATE:
-        return L"Uncorrected read errors reported to the operating system.";
-    case SMART_ATTRIBUTE_ID_SATA_DOWNSHIFT_ERROR_COUNT:
-        return L"Western Digital, Samsung or Seagate attribute: Total number of data blocks with detected, uncorrectable errors encountered during normal operation.";
-    case SMART_ATTRIBUTE_ID_END_TO_END_ERROR:
-        return L"This attribute is a part of Hewlett-Packard's SMART IV technology, as well as part of other vendors' IO Error Detection and Correction schemas, and it contains a count of parity errors which occur in the data path to the media via the drive's cache RAM.";
-    case SMART_ATTRIBUTE_ID_HEAD_STABILITY:
-        return L"Western Digital attribute.";
-    case SMART_ATTRIBUTE_ID_INDUCED_OP_VIBRATION_DETECTION:
-        return L"Western Digital attribute.";
-    case SMART_ATTRIBUTE_ID_REPORTED_UNCORRECTABLE_ERRORS:
-        return L"The count of errors that could not be recovered using hardware ECC (see attribute 195).";
-    case SMART_ATTRIBUTE_ID_COMMAND_TIMEOUT:
-        return L"The count of aborted operations due to HDD timeout. Normally this attribute value should be equal to zero and if the value is far above zero, then most likely there will be some serious problems with power supply or an oxidized data cable.";
-    case SMART_ATTRIBUTE_ID_HIGH_FLY_WRITES:
-        return L"This attribute indicates the total count of the recording head flying outside its normal operating range. If an unsafe fly height condition is encountered, the write process is stopped, and the information is rewritten or reallocated to a safe region of the hard drive. This attribute indicates the count of these errors detected over the lifetime of the drive.";
-    case SMART_ATTRIBUTE_ID_TEMPERATURE_DIFFERENCE_FROM_100:
-        return L"Airflow temperature. Value is equal to (100?temp. °C), allowing manufacturer to set a minimum threshold which corresponds to a maximum temperature.";
-    case SMART_ATTRIBUTE_ID_GSENSE_ERROR_RATE:
-        return L"";
-    case SMART_ATTRIBUTE_ID_POWER_OFF_RETRACT_COUNT:
-        return L"";
-    case SMART_ATTRIBUTE_ID_LOAD_CYCLE_COUNT:
-        return L"";
-    case SMART_ATTRIBUTE_ID_TEMPERATURE:
-        return L"";
-    case SMART_ATTRIBUTE_ID_HARDWARE_ECC_RECOVERED:
-        return L"";
-    case SMART_ATTRIBUTE_ID_REALLOCATION_EVENT_COUNT:
-        return L"";
-    case SMART_ATTRIBUTE_ID_CURRENT_PENDING_SECTOR_COUNT:
-        return L"";
-    case SMART_ATTRIBUTE_ID_UNCORRECTABLE_SECTOR_COUNT:
-        return L"";
-    case SMART_ATTRIBUTE_ID_ULTRADMA_CRC_ERROR_COUNT:
-        return L"";
-    case SMART_ATTRIBUTE_ID_MULTI_ZONE_ERROR_RATE:
-        return L"";
-    case SMART_ATTRIBUTE_ID_OFFTRACK_SOFT_READ_ERROR_RATE:
-        return L"";
-    case SMART_ATTRIBUTE_ID_DATA_ADDRESS_MARK_ERRORS:
-        return L"";
-    case SMART_ATTRIBUTE_ID_RUN_OUT_CANCEL:
-        return L"";
-    case SMART_ATTRIBUTE_ID_SOFT_ECC_CORRECTION:
-        return L"";
-    case SMART_ATTRIBUTE_ID_THERMAL_ASPERITY_RATE_TAR:
-        return L"";
-    case SMART_ATTRIBUTE_ID_FLYING_HEIGHT:
-        return L"";
-    case SMART_ATTRIBUTE_ID_SPIN_HIGH_CURRENT:
-        return L"";
-    case SMART_ATTRIBUTE_ID_SPIN_BUZZ:
-        return L"";
-    case SMART_ATTRIBUTE_ID_OFFLINE_SEEK_PERFORMANCE:
-        return L"";
-    case SMART_ATTRIBUTE_ID_VIBRATION_DURING_WRITE:
-        return L"";
-    case SMART_ATTRIBUTE_ID_SHOCK_DURING_WRITE:
-        return L"";
-    case SMART_ATTRIBUTE_ID_DISK_SHIFT:
-        return L"";
-    case SMART_ATTRIBUTE_ID_GSENSE_ERROR_RATE_ALT:
-        return L"";
-    case SMART_ATTRIBUTE_ID_LOADED_HOURS:
-        return L"";
-    case SMART_ATTRIBUTE_ID_LOAD_UNLOAD_RETRY_COUNT:
-        return L"";
-    case SMART_ATTRIBUTE_ID_LOAD_FRICTION:
-        return L"";
-    case SMART_ATTRIBUTE_ID_LOAD_UNLOAD_CYCLE_COUNT:
-        return L"";
-    case SMART_ATTRIBUTE_ID_LOAD_IN_TIME:
-        return L"";
-    case SMART_ATTRIBUTE_ID_TORQUE_AMPLIFICATION_COUNT:
-        return L"";
-    case SMART_ATTRIBUTE_ID_POWER_OFF_RETTRACT_CYCLE:
-        return L"";
-    case SMART_ATTRIBUTE_ID_GMR_HEAD_AMPLITUDE:
-        return L"";
-    case SMART_ATTRIBUTE_ID_DRIVE_TEMPERATURE:
-        return L"";
-    case SMART_ATTRIBUTE_ID_HEAD_FLYING_HOURS:
-        return L"";
-    case SMART_ATTRIBUTE_ID_TOTAL_LBA_WRITTEN:
-        return L"";
-    case SMART_ATTRIBUTE_ID_TOTAL_LBA_READ:
-        return L"";
-    case SMART_ATTRIBUTE_ID_READ_ERROR_RETY_RATE:
-        return L"";
-    case SMART_ATTRIBUTE_ID_FREE_FALL_PROTECTION:
-        return L"";
-    }
-
     return L"Unknown";
 }