Skip to content

Commit ba21c2c

Browse files
committed
Merge branch 'alexfmpe-args-chromedriver-path'
2 parents 59c2950 + 40b5728 commit ba21c2c

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

webdriver-ts/src/benchmarkRunner.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -239,10 +239,9 @@ function buildDriver() {
239239
if (args.chromeBinary) options = options.setChromeBinaryPath(args.chromeBinary);
240240
options = options.setLoggingPrefs(logPref);
241241
options = options.setPerfLoggingPrefs(<any>{enableNetwork: false, enablePage: false, enableTimeline: false, traceCategories: "devtools.timeline, disabled-by-default-devtools.timeline,blink.user_timing"});
242-
return new Builder()
243-
.forBrowser('chrome')
244-
.setChromeOptions(options)
245-
.build();
242+
243+
let service = new chrome.ServiceBuilder(args.chromeDriver).build();
244+
return chrome.Driver.createSession(options, service);
246245
}
247246

248247
async function forceGC(framework: FrameworkData, driver: WebDriver): Promise<any> {
@@ -426,6 +425,7 @@ let args = yargs(process.argv)
426425
.default('exitOnError','false')
427426
.default('count', config.REPEAT_RUN)
428427
.string('chromeBinary')
428+
.string('chromeDriver')
429429
.boolean('headless')
430430
.array("framework").array("benchmark").argv;
431431

0 commit comments

Comments
 (0)