Skip to content

Commit d5252bb

Browse files
committed
Merge branch 'args-chrome-path' of https://github.com/alexfmpe/js-framework-benchmark into alexfmpe-args-chrome-path
2 parents 10a4966 + 08f1946 commit d5252bb

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

webdriver-ts/src/benchmarkRunner.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -226,9 +226,6 @@ function buildDriver() {
226226
logPref.setLevel(logging.Type.BROWSER, logging.Level.ALL);
227227

228228
let options = new chrome.Options();
229-
// options = options.setChromeBinaryPath("/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome");
230-
// options = options.setChromeBinaryPath("/Applications/Chromium.app/Contents/MacOS/Chromium");
231-
// options = options.setChromeBinaryPath("/Applications/Google Chrome Canary.app/Contents/MacOS/Google Chrome Canary");
232229
if(args.headless) {
233230
options = options.addArguments("--headless");
234231
options = options.addArguments("--disable-gpu");
@@ -239,6 +236,7 @@ function buildDriver() {
239236
options = options.addArguments("--disable-cache");
240237
options = options.addArguments("--disable-extensions");
241238
options = options.addArguments("--window-size=1200,800")
239+
options = options.setChromeBinaryPath(args.chromeBinary);
242240
options = options.setLoggingPrefs(logPref);
243241
options = options.setPerfLoggingPrefs(<any>{enableNetwork: false, enablePage: false, enableTimeline: false, traceCategories: "devtools.timeline, disabled-by-default-devtools.timeline,blink.user_timing"});
244242
return new Builder()
@@ -427,6 +425,7 @@ let args = yargs(process.argv)
427425
.default('check','false')
428426
.default('exitOnError','false')
429427
.default('count', config.REPEAT_RUN)
428+
.string('chromeBinary')
430429
.boolean('headless')
431430
.array("framework").array("benchmark").argv;
432431

0 commit comments

Comments
 (0)