Skip to content

Commit 30dc341

Browse files
authored
chore: update CONTRIBUTING.md (GoogleCloudPlatform#1666)
1 parent b078b63 commit 30dc341

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

CONTRIBUTING.md

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -53,20 +53,24 @@ composer install
5353
```
5454

5555
### Environment variables
56-
Set up [application default credentials](https://cloud.google.com/docs/authentication/getting-started)
57-
by setting the environment variable `GOOGLE_APPLICATION_CREDENTIALS` to the path to a service
58-
account key JSON file.
56+
Some tests require specific environment variables to run. PHPUnit will skip the tests
57+
if these environment variables are not found. Run `phpunit -v` for a message detailing
58+
which environment variables are missing. Then you can set those environent variables
59+
to run against any sample project as follows:
5960

60-
Then set any environment variables needed by the test. Check the
61-
`$SAMPLES_DIRECTORY/test` directory to see what specific variables are needed.
6261
```
6362
export GOOGLE_PROJECT_ID=YOUR_PROJECT_ID
6463
export GOOGLE_STORAGE_BUCKET=YOUR_BUCKET
6564
```
6665

66+
If you have access to the Google Cloud Kokoro project, decrypt the
67+
`.kokoro/secrets.sh.enc` file and load those environment variables. Follow
68+
the instructions in [.kokoro/secrets-example.sh](.kokoro/secrets-example.sh).
69+
6770
If your tests require new environment variables, you can set them up in
68-
[.kokoro/secrets.sh.enc](.kokoro/secrets.sh.enc). For instructions on managing those variables,
69-
view [.kokoro/secrets-example.sh](.kokoro/secrets-example.sh) for more information.
71+
`.kokoro/secrets.sh.enc` so they pass on Kokoro. For instructions on managing those
72+
variables, view [.kokoro/secrets-example.sh](.kokoro/secrets-example.sh) for more
73+
information.
7074

7175
### Run the tests
7276

0 commit comments

Comments
 (0)