refactor(storage): Update Dual-Region Bucket Creation Metadata (GoogleCloudPlatform#1669)

* refactor(storage): Update Dual-Region Bucket Creation Metadata

* fix: lint

Author: danielbankhead

storage/src/create_bucket_dual_region.php

@@ -48,7 +48,13 @@ function create_bucket_dual_region($bucketName, $location, $region1, $region2)
             'dataLocations' => [$region1, $region2],
         ],
     ]);
-    printf("Bucket '%s' created in '%s' and '%s'", $bucket->name(), $region1, $region2);
+
+    $info = $bucket->info();
+
+    printf("Created '%s':", $bucket->name());
+    printf("- location: '%s'", $info['location']);
+    printf("- locationType: '%s'", $info['locationType']);
+    printf("- customPlacementConfig: '%s'" . PHP_EOL, print_r($info['customPlacementConfig'], true));
 }
 # [END storage_create_bucket_dual_region]
 

storage/test/storageTest.php

@@ -677,6 +677,7 @@ public function testCreateBucketDualRegion()
         $location = 'US';
         $region1 = 'US-EAST1';
         $region2 = 'US-WEST1';
+        $locationType = 'dual-region';
 
         $bucketName = uniqid('samples-create-bucket-dual-region-');
         $output = self::runFunctionSnippet('create_bucket_dual_region', [
@@ -692,16 +693,14 @@ public function testCreateBucketDualRegion()
         $bucket->delete();
 
         $this->assertTrue($exists);
-        $this->assertEquals(
-            sprintf(
-                "Bucket '%s' created in '%s' and '%s'",
-                $bucketName,
-                $region1,
-                $region2
-            ),
-            $output
-        );
+        $this->assertStringContainsString($bucketName, $output);
+        $this->assertStringContainsString($location, $output);
+        $this->assertStringContainsString($locationType, $output);
+        $this->assertStringContainsString($region1, $output);
+        $this->assertStringContainsString($region2, $output);
+
         $this->assertEquals($location, $info['location']);
+        $this->assertEquals($locationType, $info['locationType']);
         $this->assertArrayHasKey('customPlacementConfig', $info);
         $this->assertArrayHasKey('dataLocations', $info['customPlacementConfig']);
         $this->assertContains($region1, $info['customPlacementConfig']['dataLocations']);