address review

Author: jdpedrie

cloud_sql/mysql/pdo/src/Votes.php

@@ -20,6 +20,8 @@
 namespace Google\Cloud\Samples\CloudSQL\MySQL;
 
 use PDO;
+use PDOException;
+use RuntimeException;
 
 /**
  * Manage votes using the Cloud SQL database.
@@ -94,10 +96,28 @@ public function getCountByValue(string $value) : int
      */
     public function insertVote(string $value) : bool
     {
+        $conn = $this->connection;
+        $res = false;
+
+        # [START cloud_sql_mysql_pdo_connection]
+        // Use prepared statements to guard against SQL injection.
         $sql = "INSERT INTO votes (time_cast, vote_value) VALUES (NOW(), :voteValue)";
-        $statement = $this->connection->prepare($sql);
-        $statement->bindParam('voteValue', $value);
 
-        return $statement->execute();
+        try {
+            $statement = $conn->prepare($sql);
+            $statement->bindParam('voteValue', $value);
+
+            $res = $statement->execute();
+        } catch (PDOException $e) {
+            throw new RuntimeException(
+                "Could not insert vote into database. The PDO exception was " .
+                $e->getMessage(),
+                $e->getCode(),
+                $e
+            );
+        }
+        # [END cloud_sql_mysql_pdo_connection]
+
+        return $res;
     }
 }

cloud_sql/mysql/pdo/src/app.php

@@ -61,7 +61,13 @@
             $dsn = sprintf('mysql:dbname=%s;host=%s', $dbName, $hostname);
         }
 
-        $conn = new PDO($dsn, $username, $password);
+        // Connect to the database.
+        // Here we set the connection timeout to five seconds and ask PDO to
+        // throw an exception if any errors occur.
+        $conn = new PDO($dsn, $username, $password, [
+            PDO::ATTR_TIMEOUT => 5,
+            PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION
+        ]);
         # [END cloud_sql_mysql_pdo_create]
     } catch (TypeError $e) {
         throw new RuntimeException(
@@ -90,7 +96,6 @@
         );
     }
 
-    $conn->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
     return $conn;
 };