Skip to content

Commit bb785b8

Browse files
authored
Merge pull request adafruit#6 from GreatMindsRobotics/fix/CANSAME5x-missing-return-values
Added missing return values to CANSAME5x::filter and filterExtended
2 parents ae2de54 + 3b6f0df commit bb785b8

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/CANSAME5x.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -456,6 +456,8 @@ int CANSAME5x::filter(int id, int mask) {
456456
state->extended_rx_filter[0].XIDFE_0.bit.EFEC = CAN_XIDFE_0_EFEC_REJECT_Val;
457457
state->extended_rx_filter[0].XIDFE_1.bit.EFID2 = 0; // mask
458458
state->extended_rx_filter[0].XIDFE_1.bit.EFT = CAN_XIDFE_1_EFT_CLASSIC_Val;
459+
460+
return 1;
459461
}
460462

461463
int CANSAME5x::filterExtended(long id, long mask) {
@@ -465,11 +467,13 @@ int CANSAME5x::filterExtended(long id, long mask) {
465467
state->standard_rx_filter[0].SIDFE_0.bit.SFEC = CAN_SIDFE_0_SFEC_REJECT_Val;
466468
state->standard_rx_filter[0].SIDFE_0.bit.SFT = CAN_SIDFE_0_SFT_CLASSIC_Val;
467469

468-
// reject all extended messages
470+
// accept matching extended messages
469471
state->extended_rx_filter[0].XIDFE_0.bit.EFID1 = id;
470472
state->extended_rx_filter[0].XIDFE_0.bit.EFEC = CAN_XIDFE_0_EFEC_STF0M_Val;
471473
state->extended_rx_filter[0].XIDFE_1.bit.EFID2 = mask;
472474
state->extended_rx_filter[0].XIDFE_1.bit.EFT = CAN_XIDFE_1_EFT_CLASSIC_Val;
475+
476+
return 1;
473477
}
474478

475479
int CANSAME5x::observe() {

0 commit comments

Comments
 (0)