Initialize libssh2 from separate .cc file to avoid type redifinition conflicts

This is better than silencing the redefinition in case the two definitions really need to be different.

Author: srajko

generate/templates/manual/include/init_ssh2.h

@@ -0,0 +1,6 @@
+#ifndef INIT_SSH2
+#define INIT_SSH2
+
+void init_ssh2();
+
+#endif

generate/templates/manual/src/init_ssh2.cc

@@ -0,0 +1,12 @@
+// We are initializing libssh2 from a separate .cc file to avoid ssize_t
+// redefinition conflicts caused by incliding both node.h and libssh2.h from
+// the same file (e.g. nodegit.cc)
+//
+// The redefinition can also be avoided by #defines but that is risky in case
+// the libraries depend on the different definitions.
+
+#include <libssh2.h>
+
+void init_ssh2() {
+  libssh2_init(0);
+}

generate/templates/templates/binding.gyp

@@ -16,6 +16,7 @@
       "sources": [
         "src/lock_master.cc",
         "src/nodegit.cc",
+        "src/init_ssh2.cc",
         "src/promise_completion.cc",
         "src/wrapper.cc",
         "src/functions/copy.cc",

generate/templates/templates/nodegit.cc

@@ -8,12 +8,8 @@
 #include <set>
 
 #include <openssl/crypto.h>
-// we have to include <libssh2.h> first so it defines ssize_t
-// and then node.h with _SSIZE_T_ defined to prevent it from redefining
-// in a conflicting way on 32 bit windows
-#define ssize_t ssize_t
-#include <libssh2.h>
 
+#include "../include/init_ssh2.h"
 #include "../include/lock_master.h"
 #include "../include/wrapper.h"
 #include "../include/promise_completion.h"
@@ -75,7 +71,7 @@ void OpenSSL_ThreadSetup() {
 extern "C" void init(Local<v8::Object> target) {
   // Initialize thread safety in openssl and libssh2
   OpenSSL_ThreadSetup();
-  libssh2_init(0);
+  init_ssh2();
   // Initialize libgit2.
   git_libgit2_init();