Skip to content

Commit e9bdcf5

Browse files
author
John Haley
committed
Fix build for electron/node-webkit
1 parent c44af23 commit e9bdcf5

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

lifecycleScripts/install.js

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,8 @@ function build() {
8181
var builder = "node-gyp";
8282
var debug = (process.env.BUILD_DEBUG ? " --debug" : "");
8383
var target = "";
84-
var distUrl;
84+
var distUrl = "";
85+
var runtime = "";
8586

8687
process.argv.forEach(function(arg) {
8788
if (~arg.indexOf("electronVersion")) {
@@ -94,12 +95,13 @@ function build() {
9495

9596
if (electronVersion) {
9697
target = "--target=" + electronVersion;
97-
distUrl = "--dist-url=https://gh-contractor-zcbenz.s3." +
98-
"amazonaws.com/atom-shell/dist";
98+
distUrl = "--dist-url=https://atom.io/download/atom-shell";
99+
runtime = "--runtime=electron";
99100
}
100101
else if (nwjsVersion) {
101102
builder = "nw-gyp";
102103
target = "--target=" + nwjsVersion;
104+
runtime = "--runtime=node-webkit"
103105
}
104106

105107
var home = process.platform == "win32" ?
@@ -112,11 +114,14 @@ function build() {
112114
"rebuild",
113115
debug,
114116
target,
115-
distUrl
117+
distUrl,
118+
runtime
116119
]
117-
.join(" ")
118-
.trim()
119-
.split(" ");
120+
.filter(function(arg) {
121+
return arg;
122+
});
123+
124+
console.log(args);
120125
return new Promise(function(resolve, reject) {
121126
var child = cp.spawn(cmd, args, opts);
122127
child.on("close", function(code) {

0 commit comments

Comments
 (0)