Refactor tests for CodeUnitFindingVisitor

Author: sebastianbergmann

tests/tests/StaticAnalysis/CodeUnitFindingVisitorTest.php

@@ -28,21 +28,7 @@ final class CodeUnitFindingVisitorTest extends TestCase
      */
     public function testDoesNotFindAnonymousClass(): void
     {
-        $nodes = (new ParserFactory)->create(ParserFactory::PREFER_PHP7)->parse(
-            file_get_contents(__DIR__ . '/../../_files/ClassThatUsesAnonymousClass.php')
-        );
-
-        assert($nodes !== null);
-
-        $traverser              = new NodeTraverser;
-        $codeUnitFindingVisitor = new CodeUnitFindingVisitor;
-
-        $traverser->addVisitor(new NameResolver);
-        $traverser->addVisitor(new ParentConnectingVisitor);
-        $traverser->addVisitor($codeUnitFindingVisitor);
-
-        /* @noinspection UnusedFunctionResultInspection */
-        $traverser->traverse($nodes);
+        $codeUnitFindingVisitor = $this->findCodeUnits(__DIR__ . '/../../_files/ClassThatUsesAnonymousClass.php');
 
         $this->assertEmpty($codeUnitFindingVisitor->functions());
         $this->assertEmpty($codeUnitFindingVisitor->traits());
@@ -77,9 +63,28 @@ public function testDoesNotFindAnonymousClass(): void
      * @ticket https://github.com/sebastianbergmann/php-code-coverage/pull/797
      */
     public function testHandlesClassWithNameThatIsPartOfItsNamespacesName(): void
+    {
+        $codeUnitFindingVisitor = $this->findCodeUnits(__DIR__ . '/../../_files/ClassWithNameThatIsPartOfItsNamespacesName.php');
+
+        $this->assertEmpty($codeUnitFindingVisitor->functions());
+        $this->assertEmpty($codeUnitFindingVisitor->traits());
+
+        $classes = $codeUnitFindingVisitor->classes();
+
+        $this->assertCount(1, $classes);
+        $this->assertArrayHasKey(ClassWithNameThatIsPartOfItsNamespacesName::class, $classes);
+
+        $class = $classes[ClassWithNameThatIsPartOfItsNamespacesName::class];
+
+        $this->assertSame('ClassWithNameThatIsPartOfItsNamespacesName', $class['name']);
+        $this->assertSame(ClassWithNameThatIsPartOfItsNamespacesName::class, $class['namespacedName']);
+        $this->assertSame('SebastianBergmann\CodeCoverage\TestFixture\ClassWithNameThatIsPartOfItsNamespacesName', $class['namespace']);
+    }
+
+    private function findCodeUnits(string $filename): CodeUnitFindingVisitor
     {
         $nodes = (new ParserFactory)->create(ParserFactory::PREFER_PHP7)->parse(
-            file_get_contents(__DIR__ . '/../../_files/ClassWithNameThatIsPartOfItsNamespacesName.php')
+            file_get_contents($filename)
         );
 
         assert($nodes !== null);
@@ -94,18 +99,6 @@ public function testHandlesClassWithNameThatIsPartOfItsNamespacesName(): void
         /* @noinspection UnusedFunctionResultInspection */
         $traverser->traverse($nodes);
 
-        $this->assertEmpty($codeUnitFindingVisitor->functions());
-        $this->assertEmpty($codeUnitFindingVisitor->traits());
-
-        $classes = $codeUnitFindingVisitor->classes();
-
-        $this->assertCount(1, $classes);
-        $this->assertArrayHasKey(ClassWithNameThatIsPartOfItsNamespacesName::class, $classes);
-
-        $class = $classes[ClassWithNameThatIsPartOfItsNamespacesName::class];
-
-        $this->assertSame('ClassWithNameThatIsPartOfItsNamespacesName', $class['name']);
-        $this->assertSame(ClassWithNameThatIsPartOfItsNamespacesName::class, $class['namespacedName']);
-        $this->assertSame('SebastianBergmann\CodeCoverage\TestFixture\ClassWithNameThatIsPartOfItsNamespacesName', $class['namespace']);
+        return $codeUnitFindingVisitor;
     }
 }