Skip to content

Commit 7f6cd65

Browse files
authored
Merge pull request jobbyphp#64 from garethellis36/remove-schedule-check-from-background-job
Removes check of job schedule from BackgroundJob - see jobbyphp#62
2 parents 04fc6fe + e746ca0 commit 7f6cd65

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

src/BackgroundJob.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -198,11 +198,6 @@ protected function shouldRun()
198198
}
199199
}
200200

201-
$scheduleChecker = new ScheduleChecker();
202-
if (!$scheduleChecker->isDue($this->config['schedule'])) {
203-
return false;
204-
}
205-
206201
$host = $this->helper->getHost();
207202
if (strcasecmp($this->config['runOnHost'], $host) != 0) {
208203
return false;

tests/BackgroundJobTest.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,7 @@ public function runProvider()
6565

6666
return [
6767
'diabled, not run' => [$job + ['enabled' => false], ''],
68-
'cron schedule, not run' => [$job + ['schedule' => '0 0 1 1 *'], ''],
69-
'date time, not run' => [$job + ['schedule' => date('Y-m-d H:i:s', strtotime('tomorrow'))], ''],
70-
'date time, run' => [$job + ['schedule' => date('Y-m-d H:i:s')], 'test'],
68+
'normal job, run' => [$job, 'test'],
7169
'wrong host, not run' => [$job + ['runOnHost' => 'something that does not match'], ''],
7270
'current user, run,' => [['closure' => $uid], getmyuid()],
7371
];

0 commit comments

Comments
 (0)