chore: add cs check for return-type declaration (GoogleCloudPlatform#1202)

Author: bshaffer

.php_cs.dist

@@ -10,6 +10,9 @@ return PhpCsFixer\Config::create()
         'method_argument_space' => [
             'keep_multiple_spaces_after_comma' => true
         ],
+        'return_type_declaration' => [
+            'space_before' => 'none'
+        ],
     ])
     ->setFinder(
         PhpCsFixer\Finder::create()

appengine/php72/getting-started/test/CloudSqlTest.php

@@ -25,7 +25,7 @@ class CloudSqlTest extends TestCase
 {
     use TestTrait;
 
-    public function setUp() : void
+    public function setUp(): void
     {
         $connection = $this->requireEnv('CLOUDSQL_CONNECTION_NAME');
         $dbUser = $this->requireEnv('CLOUDSQL_USER');

cloud_sql/mysql/pdo/src/Votes.php

@@ -68,7 +68,7 @@ public function createTableIfNotExists()
      *
      * @return array
      */
-    public function listVotes() : array
+    public function listVotes(): array
     {
         $sql = "SELECT vote_value, time_cast FROM votes ORDER BY time_cast DESC LIMIT 5";
         $statement = $this->connection->prepare($sql);
@@ -82,7 +82,7 @@ public function listVotes() : array
      * @param string $value
      * @param int
      */
-    public function getCountByValue(string $value) : int
+    public function getCountByValue(string $value): int
     {
         $sql = "SELECT COUNT(vote_id) as voteCount FROM votes WHERE vote_value = ?";
 
@@ -98,7 +98,7 @@ public function getCountByValue(string $value) : int
      * @param string $value The value to vote for.
      * @return boolean
      */
-    public function insertVote(string $value) : bool
+    public function insertVote(string $value): bool
     {
         $conn = $this->connection;
         $res = false;

cloud_sql/mysql/pdo/src/app.php

@@ -54,7 +54,7 @@
 /**
  *  @param $conn_config array driver-specific options for PDO
  */
-function init_tcp_database_connection(array $conn_config) : PDO
+function init_tcp_database_connection(array $conn_config): PDO
 {
     $username = getenv('DB_USER');
     $password = getenv('DB_PASS');
@@ -107,7 +107,7 @@ function init_tcp_database_connection(array $conn_config) : PDO
 /**
  *  @param $conn_config array driver-specific options for PDO
  */
-function init_unix_database_connection(array $conn_config) : PDO
+function init_unix_database_connection(array $conn_config): PDO
 {
     $username = getenv('DB_USER');
     $password = getenv('DB_PASS');

cloud_sql/mysql/pdo/tests/VotesTest.php

@@ -29,7 +29,7 @@ class VotesTest extends TestCase
 {
     private $conn;
 
-    public function setUp() : void
+    public function setUp(): void
     {
         $this->conn = $this->prophesize(PDO::class);
     }

cloud_sql/postgres/pdo/src/Votes.php

@@ -68,7 +68,7 @@ public function createTableIfNotExists()
      *
      * @return array
      */
-    public function listVotes() : array
+    public function listVotes(): array
     {
         $sql = "SELECT vote_value, time_cast FROM votes ORDER BY time_cast DESC LIMIT 5";
         $statement = $this->connection->prepare($sql);
@@ -82,7 +82,7 @@ public function listVotes() : array
      * @param string $value
      * @param int
      */
-    public function getCountByValue(string $value) : int
+    public function getCountByValue(string $value): int
     {
         $sql = "SELECT COUNT(vote_id) as voteCount FROM votes WHERE vote_value = ?";
 
@@ -98,7 +98,7 @@ public function getCountByValue(string $value) : int
      * @param string $value The value to vote for.
      * @return boolean
      */
-    public function insertVote(string $value) : bool
+    public function insertVote(string $value): bool
     {
         $conn = $this->connection;
         $res = false;

cloud_sql/postgres/pdo/src/app.php

@@ -54,7 +54,7 @@
 /**
  *  @param $conn_config array driver-specific options for PDO
  */
-function init_tcp_database_connection(array $conn_config) : PDO
+function init_tcp_database_connection(array $conn_config): PDO
 {
     $username = getenv('DB_USER');
     $password = getenv('DB_PASS');

cloud_sql/postgres/pdo/tests/VotesTest.php

@@ -29,7 +29,7 @@ class VotesTest extends TestCase
 {
     private $conn;
 
-    public function setUp() : void
+    public function setUp(): void
     {
         $this->conn = $this->prophesize(PDO::class);
     }

cloud_sql/sqlserver/pdo/src/Votes.php

@@ -74,7 +74,7 @@ public function createTableIfNotExists()
      *
      * @return array
      */
-    public function listVotes() : array
+    public function listVotes(): array
     {
         $sql = "SELECT TOP 5 vote_value, time_cast FROM votes ORDER BY time_cast DESC";
         $statement = $this->connection->prepare($sql);
@@ -88,7 +88,7 @@ public function listVotes() : array
      * @param string $value
      * @param int
      */
-    public function getCountByValue(string $value) : int
+    public function getCountByValue(string $value): int
     {
         $sql = "SELECT COUNT(vote_id) as voteCount FROM votes WHERE vote_value = ?";
 
@@ -104,7 +104,7 @@ public function getCountByValue(string $value) : int
      * @param string $value The value to vote for.
      * @return boolean
      */
-    public function insertVote(string $value) : bool
+    public function insertVote(string $value): bool
     {
         $conn = $this->connection;
         $res = false;

cloud_sql/sqlserver/pdo/tests/VotesTest.php

@@ -29,7 +29,7 @@ class VotesTest extends TestCase
 {
     private $conn;
 
-    public function setUp() : void
+    public function setUp(): void
     {
         $this->conn = $this->prophesize(PDO::class);
     }