Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jskeet/DemoCode
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: jskeet/DemoCode
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: compat-issue
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 5 files changed
  • 1 contributor

Commits on Mar 20, 2024

  1. Initial setup and release of 1.0.0 

    Class1 contains a void parameterless method, and an Int32-returning
property.

The project targets netstandard2.1.
    @jskeet
    jskeet committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    c538423 View commit details
    Browse the repository at this point in the history

  2. Add a nullable-returning property and an enum, and release 1.1.0 

    Note: changing the target framework to netstandard2.0 at *this*
point does not cause any compatibility errors.
    @jskeet
    jskeet committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    e0065b0 View commit details
    Browse the repository at this point in the history

  3. Change the target to netstandard2.0 and try to release 1.2.0 

    This fails to pack with compatibility errors:

```text
error : API compatibility errors between 'lib/netstandard2.1/CompatIssue.dll' (...\packages\compatissue\1.1.0\compatissue.1.1.0.nupkg) and 'lib/netstandard2.0/CompatIssue.dll' (...\CompatIssue.csproj)
error CP0002: Member 'System.Nullable<int> CompatIssue.Class1.NullableProperty.get' exists on [Baseline] lib/netstandard2.1/CompatIssue.dll but not on lib/netstandard2.0/CompatIssue.dll [...\CompatIssue.csproj]
error CP0002: Member 'CompatIssue.SampleEnum CompatIssue.SampleEnum.Value0' exists on [Baseline] lib/netstandard2.1/CompatIssue.dll but not on lib/netstandard2.0/CompatIssue.dll [...\CompatIssue.csproj]
error CP0002: Member 'CompatIssue.SampleEnum CompatIssue.SampleEnum.Value1' exists on [Baseline] lib/netstandard2.1/CompatIssue.dll but not on lib/netstandard2.0/CompatIssue.dll [...\CompatIssue.csproj]
```
    @jskeet
    jskeet committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    91aa6db View commit details
    Browse the repository at this point in the history
Loading