Fix file URI perf regression

Summary:
The CSRF changes meant that we can't generate a file URI with just its PHID
anymore, and converted a mathematical function into a service call.
Unfortunately, this caused massive perf problems in some parts of the
application, critically handles, where loading N users became N single gets.
Derp derp derp. Remedy this by doing a single multiget. This substantially
improves performance of many interfaces, particularly the Maniphest task list.

I need to go through the rest of the PhabricatorFileURI callsites and get rid of
them, but I think this is the most substantive one.

Test Plan: Profiled Maniphest task list, queries went from >100 to a handful.
Explosion of multiderp. :/ Looked at some views with profile photos to verify
they still render accurately.

Reviewers: jungejason, nh, tuomaspelkonen, aran

Reviewed By: aran

CC: aran

Differential Revision: 921

Author: epriestley

src/applications/phid/handle/data/PhabricatorObjectHandleData.php

@@ -132,6 +132,17 @@ public function loadHandles() {
           $users = $object->loadAllWhere('phid IN (%Ls)', $phids);
           $users = mpull($users, null, 'getPHID');
 
+          $image_phids = mpull($users, 'getProfileImagePHID');
+          $image_phids = array_unique(array_filter($image_phids));
+
+          $images = array();
+          if ($image_phids) {
+            $images = id(new PhabricatorFile())->loadAllWhere(
+              'phid IN (%Ls)',
+              $image_phids);
+            $images = mpull($images, 'getViewURI', 'getPHID');
+          }
+
           foreach ($phids as $phid) {
             $handle = new PhabricatorObjectHandle();
             $handle->setPHID($phid);
@@ -148,10 +159,9 @@ public function loadHandles() {
               $handle->setAlternateID($user->getID());
               $handle->setComplete(true);
 
-              $img_phid = $user->getProfileImagePHID();
-              if ($img_phid) {
-                $handle->setImageURI(
-                  PhabricatorFileURI::getViewURIForPHID($img_phid));
+              $img_uri = idx($images, $user->getProfileImagePHID());
+              if ($img_uri) {
+                $handle->setImageURI($img_uri);
               }
             }
             $handles[$phid] = $handle;

src/applications/phid/handle/data/__init__.php

@@ -7,7 +7,7 @@
 
 
 phutil_require_module('phabricator', 'applications/differential/constants/revisionstatus');
-phutil_require_module('phabricator', 'applications/files/uri');
+phutil_require_module('phabricator', 'applications/files/storage/file');
 phutil_require_module('phabricator', 'applications/maniphest/constants/owner');
 phutil_require_module('phabricator', 'applications/maniphest/constants/status');
 phutil_require_module('phabricator', 'applications/phid/constants');