Skip to content

Commit 21e566d

Browse files
alan-agius4benlesh
authored andcommitted
build: use nodejs public api (angular#25940)
`nodejs_binary` and `nodejs_test` from `@build_bazel_rules_nodejs//:defs.bzl` and `@build_bazel_rules_nodejs//internal/node:node.bzl` are different as the first one uses a macro https://github.com/bazelbuild/rules_nodejs/blob/master/internal/node/node.bzl#L229 to wrap the `nodejs_binary` and `nodejs_test` as an `.exe` for Windows. PR Close angular#25940
1 parent bdbb2f9 commit 21e566d

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

tools/ts-api-guardian/index.bzl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"""Runs ts_api_guardian
1616
"""
1717

18-
load("@build_bazel_rules_nodejs//internal/node:node.bzl", "nodejs_binary", "nodejs_test")
18+
load("@build_bazel_rules_nodejs//:defs.bzl", "nodejs_binary", "nodejs_test")
1919

2020
COMMON_MODULE_IDENTIFIERS = ["angular", "jasmine", "protractor"]
2121

@@ -25,7 +25,6 @@ def ts_api_guardian_test(name, golden, actual, data = [], strip_export_pattern =
2525
data += [
2626
"@angular//tools/ts-api-guardian:lib",
2727
"@angular//tools/ts-api-guardian:bin/ts-api-guardian",
28-
"@bazel_tools//tools/bash/runfiles",
2928
]
3029

3130
args = [
@@ -44,7 +43,6 @@ def ts_api_guardian_test(name, golden, actual, data = [], strip_export_pattern =
4443
node_modules = "@ts-api-guardian_runtime_deps//:node_modules",
4544
entry_point = "angular/tools/ts-api-guardian/bin/ts-api-guardian",
4645
templated_args = args + ["--verify", golden, actual],
47-
testonly = 1,
4846
**kwargs
4947
)
5048

0 commit comments

Comments
 (0)