Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rails/rails
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: keithpitty/rails
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on Apr 14, 2017

  1. Correct explanation of strong parameters 

    This change corrects a misunderstanding of the way required parameters
are handled. Whilst there is an exception wrapper that maps
ActionController::ParameterMissing to a 400 bad request, this is only
used in logging. The current description implies that the exception is
caught and a 400 Bad Request response is sent. This is not the case.
    @keithpitty
    keithpitty committed Apr 14, 2017
    Configuration menu
    Copy the full SHA
    2ac149d View commit details
    Browse the repository at this point in the history

  2. Clean up comment alignment

    @keithpitty
    keithpitty committed Apr 14, 2017
    Configuration menu
    Copy the full SHA
    34a3eb3 View commit details
    Browse the repository at this point in the history

  3. Clarify configuration documentation 

    This change clarifies the purpose of the
action_dispatch.rescue_responses configuration by stating the fact that
no exceptions in this hash are actually rescued. Rather, the hash is
used for logging purposes.
    @keithpitty
    keithpitty committed Apr 14, 2017
    Configuration menu
    Copy the full SHA
    bd792a2 View commit details
    Browse the repository at this point in the history
Loading