Don't use Netty's ThrowableUtil which is internal

Author: slandelle

client/src/main/java/org/asynchttpclient/exception/ChannelClosedException.java

@@ -12,9 +12,9 @@
  */
 package org.asynchttpclient.exception;
 
-import java.io.IOException;
+import static org.asynchttpclient.util.ThrowableUtil.unknownStackTrace;
 
-import static io.netty.util.internal.ThrowableUtil.*;
+import java.io.IOException;
 
 @SuppressWarnings("serial")
 public final class ChannelClosedException extends IOException {

client/src/main/java/org/asynchttpclient/exception/PoolAlreadyClosedException.java

@@ -12,7 +12,7 @@
  */
 package org.asynchttpclient.exception;
 
-import static io.netty.util.internal.ThrowableUtil.unknownStackTrace;
+import static org.asynchttpclient.util.ThrowableUtil.unknownStackTrace;
 
 import java.io.IOException;
 

client/src/main/java/org/asynchttpclient/exception/RemotelyClosedException.java

@@ -12,7 +12,7 @@
  */
 package org.asynchttpclient.exception;
 
-import static io.netty.util.internal.ThrowableUtil.unknownStackTrace;
+import static org.asynchttpclient.util.ThrowableUtil.unknownStackTrace;
 
 import java.io.IOException;
 

client/src/main/java/org/asynchttpclient/netty/channel/ConnectionSemaphore.java

@@ -13,15 +13,15 @@
  */
 package org.asynchttpclient.netty.channel;
 
+import static org.asynchttpclient.util.ThrowableUtil.unknownStackTrace;
+
 import java.io.IOException;
 import java.util.concurrent.ConcurrentHashMap;
 
 import org.asynchttpclient.AsyncHttpClientConfig;
 import org.asynchttpclient.exception.TooManyConnectionsException;
 import org.asynchttpclient.exception.TooManyConnectionsPerHostException;
 
-import static io.netty.util.internal.ThrowableUtil.unknownStackTrace;
-
 /**
  * Max connections and max-per-host connections limiter.
  *

client/src/main/java/org/asynchttpclient/netty/handler/intercept/Redirect30xInterceptor.java

@@ -14,11 +14,11 @@
 package org.asynchttpclient.netty.handler.intercept;
 
 import static io.netty.handler.codec.http.HttpHeaderNames.*;
-import static io.netty.util.internal.ThrowableUtil.unknownStackTrace;
 import static org.asynchttpclient.util.HttpConstants.Methods.GET;
 import static org.asynchttpclient.util.HttpConstants.ResponseStatusCodes.*;
 import static org.asynchttpclient.util.HttpUtils.*;
 import static org.asynchttpclient.util.MiscUtils.isNonEmpty;
+import static org.asynchttpclient.util.ThrowableUtil.unknownStackTrace;
 import io.netty.channel.Channel;
 import io.netty.handler.codec.http.HttpHeaders;
 import io.netty.handler.codec.http.HttpResponse;

client/src/main/java/org/asynchttpclient/util/ThrowableUtil.java

@@ -0,0 +1,31 @@
+/*
+ * Copyright (c) 2017 AsyncHttpClient Project. All rights reserved.
+ *
+ * This program is licensed to you under the Apache License Version 2.0,
+ * and you may not use this file except in compliance with the Apache License Version 2.0.
+ * You may obtain a copy of the Apache License Version 2.0 at http://www.apache.org/licenses/LICENSE-2.0.
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the Apache License Version 2.0 is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the Apache License Version 2.0 for the specific language governing permissions and limitations there under.
+ */
+package org.asynchttpclient.util;
+
+public final class ThrowableUtil {
+
+    private ThrowableUtil() {
+    }
+
+    /**
+     * @param <T> the Throwable type
+     * @param t the throwable whose stacktrace we want to remove
+     * @param clazz the caller class
+     * @param method the caller method
+     * @return the input throwable with removed stacktrace
+     */
+    public static <T extends Throwable> T unknownStackTrace(T t, Class<?> clazz, String method) {
+        t.setStackTrace(new StackTraceElement[] { new StackTraceElement(clazz.getName(), method, null, -1) });
+        return t;
+    }
+}

client/src/test/java/org/asynchttpclient/AsyncStreamHandlerTest.java

@@ -16,10 +16,10 @@
 package org.asynchttpclient;
 
 import static io.netty.handler.codec.http.HttpHeaderNames.*;
-import static io.netty.util.internal.ThrowableUtil.unknownStackTrace;
 import static java.nio.charset.StandardCharsets.US_ASCII;
 import static org.asynchttpclient.Dsl.config;
 import static org.asynchttpclient.test.TestUtils.*;
+import static org.asynchttpclient.util.ThrowableUtil.unknownStackTrace;
 import static org.testng.Assert.*;
 import io.netty.handler.codec.http.HttpHeaderValues;
 import io.netty.handler.codec.http.HttpHeaders;

client/src/test/java/org/asynchttpclient/BasicHttpTest.java

@@ -14,12 +14,12 @@
 package org.asynchttpclient;
 
 import static io.netty.handler.codec.http.HttpHeaderNames.*;
-import static io.netty.util.internal.ThrowableUtil.unknownStackTrace;
 import static java.nio.charset.StandardCharsets.ISO_8859_1;
 import static java.util.concurrent.TimeUnit.SECONDS;
 import static org.asynchttpclient.Dsl.*;
 import static org.asynchttpclient.test.TestUtils.*;
 import static org.asynchttpclient.util.DateUtils.unpreciseMillisTime;
+import static org.asynchttpclient.util.ThrowableUtil.unknownStackTrace;
 import static org.testng.Assert.*;
 import io.netty.handler.codec.http.DefaultHttpHeaders;
 import io.netty.handler.codec.http.HttpHeaderValues;